Skip to content

Public the Menu Parameters set API #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented May 9, 2022

Fixes #5944 #4641

Description

We can ignore the System settings by the code:

        SystemParameters.StaticPropertyChanged += (sender, eventArgs) =>
        {
            SystemParameters.MenuDropAlignment = false;
        };

cc @miloush

Customer Impact

Regression

Testing

CI and My demo

Risk

Low.

Microsoft Reviewers: Open in CodeFlow

We can control it and ignore the System settings.
@lindexi lindexi requested a review from a team as a code owner May 9, 2022 09:37
@ghost ghost assigned lindexi May 9, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label May 9, 2022
@ghost ghost requested review from dipeshmsft, singhashish-wpf and SamBent May 9, 2022 09:37
@ghost ghost added the Community Contribution A label for all community Contributions label May 9, 2022
@miloush
Copy link
Contributor

miloush commented May 9, 2022

Wouldn't be possible for the setters to actually set the system parameters? How do users cancel the override? Could we rather not fix the consumers to use MenuDropAlignmentKey as a dynamic resource and override it in app resources?

@lindexi lindexi changed the base branch from main to 3.1darc May 11, 2022 11:27
@lindexi lindexi changed the base branch from 3.1darc to main May 11, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Review Requested Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup element are reversed left and right in Windows 11
3 participants