Skip to content

Refactor DesignerSerializationManager to replace HashTable and enable Nullability #8353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 9, 2023
Merged

Refactor DesignerSerializationManager to replace HashTable and enable Nullability #8353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
6a66e03
Refactored to remove HashTable
elachlan Dec 9, 2022
41395a0
changes from review
elachlan Dec 14, 2022
c15aa48
changes from review
elachlan Dec 15, 2022
de0da2c
more changes
elachlan Dec 15, 2022
b33509f
remove null check
elachlan Dec 17, 2022
dd8c238
rebase and minor refactor
elachlan Dec 19, 2022
28c6ebf
change from review
elachlan Dec 20, 2022
7d71e3e
Small refactor to remove null warning
elachlan Dec 20, 2022
e8cac5d
added debug.assert check for instance
elachlan Dec 20, 2022
b76e0b1
change from review
elachlan Jan 18, 2023
3133ddd
Fix test failure
elachlan Jan 18, 2023
6740baf
Change `GetRuntimeType` back
elachlan Jan 19, 2023
b9bc0f7
Fix DesignerSerializationManager_Errors_GetWithSession_ReturnsExpecte…
elachlan Jan 19, 2023
51ca1eb
fix a couple more tests
elachlan Jan 19, 2023
35dd3a2
Fix test failures of DesignerSerializationManager
elachlan Jan 23, 2023
2b96ab6
changes from review
elachlan Jan 26, 2023
3df6086
Fix SerializationProviders property
elachlan Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,15 +359,15 @@ System.ComponentModel.Design.ProjectTargetFrameworkAttribute.TargetFrameworkMoni
~System.ComponentModel.Design.Serialization.CodeDomSerializerException.CodeDomSerializerException(System.Exception ex, System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager) -> void
~System.ComponentModel.Design.Serialization.CodeDomSerializerException.LinePragma.get -> System.CodeDom.CodeLinePragma
~System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer.MethodSupportsSerialization(System.Reflection.MethodInfo method) -> bool
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.Container.get -> System.ComponentModel.IContainer
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.Container.set -> void
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateSession() -> System.IDisposable
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.DesignerSerializationManager(System.IServiceProvider provider) -> void
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.Errors.get -> System.Collections.IList
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetRuntimeType(string typeName) -> System.Type
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetSerializer(System.Type objectType, System.Type serializerType) -> object
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.PropertyProvider.get -> object
~System.ComponentModel.Design.Serialization.DesignerSerializationManager.PropertyProvider.set -> void
System.ComponentModel.Design.Serialization.DesignerSerializationManager.Container.get -> System.ComponentModel.IContainer?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.Container.set -> void
System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateSession() -> System.IDisposable!
System.ComponentModel.Design.Serialization.DesignerSerializationManager.DesignerSerializationManager(System.IServiceProvider? provider) -> void
System.ComponentModel.Design.Serialization.DesignerSerializationManager.Errors.get -> System.Collections.IList!
System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetRuntimeType(string? typeName) -> System.Type?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetSerializer(System.Type? objectType, System.Type! serializerType) -> object?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.PropertyProvider.get -> object?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.PropertyProvider.set -> void
~System.ComponentModel.Design.Serialization.ExpressionContext.Expression.get -> System.CodeDom.CodeExpression
~System.ComponentModel.Design.Serialization.ExpressionContext.ExpressionContext(System.CodeDom.CodeExpression expression, System.Type expressionType, object owner) -> void
~System.ComponentModel.Design.Serialization.ExpressionContext.ExpressionContext(System.CodeDom.CodeExpression expression, System.Type expressionType, object owner, object presetValue) -> void
Expand Down Expand Up @@ -635,12 +635,12 @@ virtual System.ComponentModel.Design.DesignerCommandSet.GetCommands(string! name
~virtual System.ComponentModel.Design.Serialization.CodeDomSerializer.SerializeMember(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, object owningObject, System.ComponentModel.MemberDescriptor member) -> System.CodeDom.CodeStatementCollection
~virtual System.ComponentModel.Design.Serialization.CodeDomSerializer.SerializeMemberAbsolute(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, object owningObject, System.ComponentModel.MemberDescriptor member) -> System.CodeDom.CodeStatementCollection
~virtual System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer.SerializeCollection(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeExpression targetExpression, System.Type targetType, System.Collections.ICollection originalCollection, System.Collections.ICollection valuesToSerialize) -> object
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateInstance(System.Type type, System.Collections.ICollection arguments, string name, bool addToContainer) -> object
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type serviceType) -> object
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetType(string typeName) -> System.Type
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnResolveName(System.ComponentModel.Design.Serialization.ResolveNameEventArgs e) -> void
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionCreated(System.EventArgs e) -> void
~virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionDisposed(System.EventArgs e) -> void
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateInstance(System.Type! type, System.Collections.ICollection? arguments, string? name, bool addToContainer) -> object!
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type! serviceType) -> object?
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetType(string? typeName) -> System.Type?
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnResolveName(System.ComponentModel.Design.Serialization.ResolveNameEventArgs! e) -> void
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionCreated(System.EventArgs! e) -> void
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionDisposed(System.EventArgs! e) -> void
~virtual System.ComponentModel.Design.Serialization.TypeCodeDomSerializer.Deserialize(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeTypeDeclaration declaration) -> object
~virtual System.ComponentModel.Design.Serialization.TypeCodeDomSerializer.GetInitializeMethod(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeTypeDeclaration declaration, object value) -> System.CodeDom.CodeMemberMethod
~virtual System.ComponentModel.Design.Serialization.TypeCodeDomSerializer.GetInitializeMethods(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeTypeDeclaration declaration) -> System.CodeDom.CodeMemberMethod[]
Expand Down Expand Up @@ -892,8 +892,8 @@ System.ComponentModel.Design.Serialization.DesignerSerializationManager.Preserve
System.ComponentModel.Design.Serialization.DesignerSerializationManager.PreserveNames.set -> void
System.ComponentModel.Design.Serialization.DesignerSerializationManager.RecycleInstances.get -> bool
System.ComponentModel.Design.Serialization.DesignerSerializationManager.RecycleInstances.set -> void
System.ComponentModel.Design.Serialization.DesignerSerializationManager.SessionCreated -> System.EventHandler
System.ComponentModel.Design.Serialization.DesignerSerializationManager.SessionDisposed -> System.EventHandler
System.ComponentModel.Design.Serialization.DesignerSerializationManager.SessionCreated -> System.EventHandler?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.SessionDisposed -> System.EventHandler?
System.ComponentModel.Design.Serialization.DesignerSerializationManager.ValidateRecycledTypes.get -> bool
System.ComponentModel.Design.Serialization.DesignerSerializationManager.ValidateRecycledTypes.set -> void
System.ComponentModel.Design.Serialization.ExpressionContext
Expand Down
Loading