Porting several outstanding UITypeEditors
#2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RussKie
changed the title
UITypeEditors
Codecov Report
@@ Coverage Diff @@
## release/3.1 #2288 +/- ##
=====================================================
- Coverage 25.23939% 24.87572% -0.36367%
=====================================================
Files 814 844 +30
Lines 256171 260290 +4119
Branches 36525 36896 +371
=====================================================
+ Hits 64656 64749 +93
- Misses 186785 190824 +4039
+ Partials 4730 4717 -13
|
RussKie
force-pushed
the
release/3.1-uitypeeditors
branch
from
11ee307 to
58d9676
Compare
dreddy-work
reviewed
Nov 5, 2019
There was a problem hiding this comment.
@RussKie one quick thing, we were trying to get rid of comment portion from resx files in core ( commented above). This should be a one time change ( until we make template change in VS?).
leecow
added
servicing-approved
RussKie
added
the
🚫 * NO-MERGE *
* Add editors we missed to the table of intrinsic editors * Add positive ack test for editors associated in the table * Add entries in test for editors only attached with editor attribute * Add editor type to editor test and create basic test for properties * Add stubs for all known editors requireing porting
Closes #2116
Closes #2020
RussKie
force-pushed
the
release/3.1-uitypeeditors
branch
from
ff40778 to
c06ca68
Compare
Change editor reference of `ToolStripItem.ImageIndex` to `ImageIndexEditor` like other `ImageIndex` public surface in other controls.
Closes #2019
Whilst we do not support nor cant be expected to support customers who reference our internals, in some scenarios like `UITypeEditor`s and `TypeConverter`s may still be used by consumers to enhance their runtime experience. E.g. #2078 (comment) Type forward `DataMemberFieldConverter` to avoid breaking existing customers. Relates to #1545
RussKie
force-pushed
the
release/3.1-uitypeeditors
branch
from
c06ca68 to
a299459
Compare
RussKie
force-pushed
the
release/3.1-uitypeeditors
branch
from
a299459 to
44927a9
Compare
RussKie
removed
the
🚫 * NO-MERGE *
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #1115
Proposed changes
UITypeEditorsImageIndexEditor(Closes Port ImageIndexEditor #2115)IconEditor(Closes PortSystem.Drawing.Design.IconEditor#2020)TabPageCollectionEditor(Closes Port System.Windows.Forms.Design.TabPageCollectionEditor #1281)ContentAlignmentEditor(Closes PortSystem.Drawing.Design.ContentAlignmentEditor#2018)ListControlStringCollectionEditor(Closes Port System.Windows.Forms.Design.ListControlStringCollectionEditor #1271)BinaryEditor(Closes PortSystem.ComponentModel.Design.BinaryEditor#2017)DateTimeEditor(Closes PortSystem.ComponentModel.Design.DateTimeEditor#2019)ListViewSubItemCollectionEditor(Closes Port System.Windows.Forms.Design.ListViewSubItemCollectionEditor #1277)ListViewGroupCollectionEditor(Closes Port System.Windows.Forms.Design.ListViewGroupCollectionEditor #1275)ListViewItemCollectionEditor(Closes Port System.Windows.Forms.Design.ListViewItemCollectionEditor #1276)SelectedPathEditor(Closes Port SelectedPathEditor #2282)LinkAreaEditor(Closes Port LinkAreaEditor #2284)FormatStringEditor(Closes Port FormatStringEditor #2281)HelpNamespaceEditor(Closes Port HelpNamespaceEditor #2283)MaskedTextBoxTextEditor(Closes Port MaskedTextBoxTextEditor #2286)MaskPropertyEditor(Closes Port MaskPropertyEditor #2285)Whilst we do not support nor cant be expected to support customers who reference our internals, in some scenarios like
UITypeEditors andTypeConverters may still be used by consumers to enhance their runtime experience.E.g. Porting System.Windows.Forms.Design.ListControlStringCollectionEditor #2078 (comment)
Type forward
DataMemberFieldConverterto avoid breaking existing customers.Relates to #1545
Customer Impact
PropertyGridcontrol.NB: The VS Desginer has its own set of editors.
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow