Porting System.Windows.Forms.Design.ListViewGroupCollectionEditor #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-krestov
added
the
waiting-review
73 tasks
Codecov Report
@@ Coverage Diff @@
## release/3.1-uitypeeditors #2196 +/- ##
==================================================================
- Coverage 26.40136% 26.3335% -0.06786%
==================================================================
Files 816 817 +1
Lines 269577 269611 +34
Branches 38235 38238 +3
==================================================================
- Hits 71172 70998 -174
- Misses 193326 193535 +209
+ Partials 5079 5078 -1
|
|
Needs review. |
zsd4yr
suggested changes
Oct 25, 2019
src/System.Windows.Forms/src/System/Drawing/Design/UITypeEditor.cs
Outdated
Show resolved
Hide resolved
ghost
added
the
waiting-author-feedback
RussKie
removed
the
waiting-review
vladimir-krestov
force-pushed
the
dev/v-vlkres/ListViewGroupCollectionEditor_Port
branch
from
228d920 to
fc4cdfe
Compare
ghost
removed
the
waiting-author-feedback
|
Squashed commits. Added ListViewGroupCollectionEditor unit test case. |
vladimir-krestov
added
the
waiting-review
RussKie
previously approved these changes
Oct 29, 2019
| /// </summary> | ||
| internal class ListViewGroupCollectionEditor : CollectionEditor | ||
| { | ||
| object _editValue; |
There was a problem hiding this comment.
Suggested change
| object _editValue; | |
| private object _editValue; |
There was a problem hiding this comment.
Thanks, fixed.
RussKie
removed
the
waiting-review
vladimir-krestov
force-pushed
the
dev/v-vlkres/ListViewGroupCollectionEditor_Port
branch
from
fc4cdfe to
bc3eeb2
Compare
RussKie
previously approved these changes
Oct 29, 2019
RussKie
force-pushed
the
dev/v-vlkres/ListViewGroupCollectionEditor_Port
branch
from
bc3eeb2 to
c7616c2
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1275
Related issue: #1115
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow