Skip to content

Conversation

RussKie
Copy link
Contributor

@RussKie RussKie commented Aug 2, 2019

Fixes #1210
Fixes #1272

Proposed changes

  • Port StringArrayEditor from NET Fx
  • Revert "Disable WinFormsControlsClassicTests.csproj on non-windows platforms" 16bb16d as it prevents the project from building on Windows platform too.

Customer Impact

  • StringArrayEditor is now available

Regression?

  • Yes

Risk

  • Minimal, if any

Screenshots

Before

image

After

image

Test methodology

  • manual / visual
Microsoft Reviewers: Open in CodeFlow

@RussKie RussKie requested a review from a team as a code owner August 2, 2019 09:15
@RussKie RussKie changed the title Fix 1272 Port StringArrayEditor from NET Fx WIP: Fix 1272 Port StringArrayEditor from NET Fx Aug 2, 2019
@ghost ghost added this to the 3.0.0-Preview9 milestone Aug 2, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #1552 into release/3.1 will decrease coverage by 0.03079%.
The diff coverage is 0%.

@@                 Coverage Diff                  @@
##           release/3.1       #1552        +/-   ##
====================================================
- Coverage     26.52036%   26.48956%   -0.0308%     
====================================================
  Files              804         805         +1     
  Lines           268062      268083        +21     
  Branches         38066       38068         +2     
====================================================
- Hits             71091       71014        -77     
- Misses          191895      191987        +92     
- Partials          5076        5082         +6
Flag Coverage Δ
#Debug 26.48956% <0%> (-0.0308%) ⬇️
#production 26.48956% <0%> (-0.0308%) ⬇️
#test 100% <ø> (ø) ⬆️

@RussKie RussKie force-pushed the fix_1272_Port_StringArrayEditor branch from 8ded791 to 078afb8 Compare August 2, 2019 13:16
@RussKie RussKie changed the title WIP: Fix 1272 Port StringArrayEditor from NET Fx Fix 1272 Port StringArrayEditor from NET Fx Aug 2, 2019
@RussKie RussKie added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Aug 2, 2019
@RussKie
Copy link
Contributor Author

RussKie commented Aug 6, 2019

CTI has come back with unexpected changes in behaviour for the DomainUpDown control's Items property.
I will need to investigate it further.

@RussKie RussKie changed the title Fix 1272 Port StringArrayEditor from NET Fx WIP: Fix 1272 Port StringArrayEditor from NET Fx Aug 6, 2019
@RussKie RussKie added the 💥 regression-preview Regression from a preview release label Aug 6, 2019
@RussKie RussKie added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 13, 2019
@RussKie RussKie modified the milestones: 3.0.0-Preview9, Future Aug 13, 2019
@RussKie RussKie removed the tell-mode label Aug 14, 2019
@RussKie RussKie removed the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 4, 2019
@RussKie RussKie modified the milestones: Future, 3.1 Sep 16, 2019
@RussKie RussKie force-pushed the fix_1272_Port_StringArrayEditor branch from 078afb8 to 7f6733f Compare September 18, 2019 13:44
@RussKie RussKie changed the base branch from master to release/3.1 September 18, 2019 13:45
@RussKie RussKie force-pushed the fix_1272_Port_StringArrayEditor branch from 7f6733f to 2be9bc1 Compare September 18, 2019 13:59
@RussKie RussKie changed the title WIP: Fix 1272 Port StringArrayEditor from NET Fx Fix 1272 Port StringArrayEditor from NET Fx Sep 18, 2019
@RussKie RussKie self-assigned this Oct 3, 2019
@RussKie RussKie removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Oct 15, 2019
@RussKie RussKie force-pushed the fix_1272_Port_StringArrayEditor branch from 2be9bc1 to f123da5 Compare October 16, 2019 02:20
@RussKie RussKie merged commit 2b47acb into dotnet:release/3.1 Oct 16, 2019
@RussKie RussKie deleted the fix_1272_Port_StringArrayEditor branch October 16, 2019 02:28
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-DesignerSupport 💥 regression-preview Regression from a preview release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant