Skip to content

Handle transient GDI+ ExternalException in SplitContainer.RepaintSplitterRect during display-session transition #14565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeafShi1 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −7
Open

Handle transient GDI+ ExternalException in SplitContainer.RepaintSplitterRect during display-session transition #14565

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60441d4
Handle transient GDI+ ExternalException in SplitContainer.RepaintSpli…
LeafShi1 May 27, 2026
4e84aa1
Add Debug.Fail for ExternalException to prevent silent failures
LeafShi1 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/System.Windows.Forms/System/Windows/Forms/Layout/Containers/SplitContainer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,16 +1550,25 @@ private void RepaintSplitterRect()
{
if (IsHandleCreated)
{
using Graphics g = CreateGraphicsInternal();
if (BackgroundImage is not null)
try
{
using TextureBrush textureBrush = new(BackgroundImage, WrapMode.Tile);
g.FillRectangle(textureBrush, ClientRectangle);
using Graphics g = CreateGraphicsInternal();
if (BackgroundImage is not null)
{
using TextureBrush textureBrush = new(BackgroundImage, WrapMode.Tile);
g.FillRectangle(textureBrush, ClientRectangle);
}
else
{
using var solidBrush = BackColor.GetCachedSolidBrushScope();
g.FillRectangle(solidBrush, _splitterRect);
}
}
else
catch (ExternalException ex)
{
using var solidBrush = BackColor.GetCachedSolidBrushScope();
g.FillRectangle(solidBrush, _splitterRect);
// GDI+ can transiently fail while the display session is transitioning (for example, lock/unlock).
// Ignore repaint failures here and let normal painting recover once graphics resources are available.
Debug.Fail($"{nameof(RepaintSplitterRect)} failed with hr={ex.ErrorCode}, message={ex}");
}
}
}
Expand Down
Loading