Skip to content

[DRAFT] VMR Verification in SBRP PRs #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[DRAFT] VMR Verification in SBRP PRs #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45b9b67
New pipeline yml
NikolaMilosavljevic Jun 17, 2025
838c8ba
Test more
NikolaMilosavljevic Jun 17, 2025
9683d62
Update repo template
NikolaMilosavljevic Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions azure-pipelines/builds/vmr-build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
trigger: none
pr: none

variables:
- template: /eng/common/templates/variables/pool-providers.yml@self

- name: skipComponentGovernanceDetection # we run CG on internal builds only
value: true

- name: Codeql.Enabled # we run CodeQL on internal builds only
value: false

resources:
repositories:
- repository: vmr
type: github
name: dotnet/dotnet
endpoint: dotnet
ref: refs/heads/vmrverification.list

stages:
- template: /eng/pipelines/templates/stages/vmr-build.yml@vmr
parameters:
isBuiltFromVmr: false
verifications: [ "source-build-stage1" ]
scope: lite
2 changes: 2 additions & 0 deletions eng/common/templates/vmr-build-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ resources:
type: github
name: dotnet/dotnet
endpoint: dotnet
ref: refs/heads/vmrverification.list

stages:
- template: /eng/pipelines/templates/stages/vmr-build.yml@vmr
parameters:
isBuiltFromVmr: false
verifications: [ "source-build-stage1" ]
scope: lite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHat's the difference between scope and verifications?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope is used to condition jobs in CI and PRs, in an all-or-nothing fashion. lite jobs are considered a subset of full.

verifications contains the list of jobs that are considered to be verifications and currently ran in both lite and full scopes. This parameter allow us to only run specific verifications. This might only make sense for lite scope, therefore I added the scope parameter to be explicit.

Here's where scope is currently used: https://github.com/dotnet/dotnet/blob/1ec8c1e9aebde14c1813d1c878dda7fd38ab298f/eng/pipelines/templates/stages/source-build-stages.yml#L65 and https://github.com/dotnet/dotnet/blob/1ec8c1e9aebde14c1813d1c878dda7fd38ab298f/eng/pipelines/templates/stages/vmr-verticals.yml#L171

lite is the first value listed, so it is the implicit default value - https://github.com/dotnet/dotnet/blob/1ec8c1e9aebde14c1813d1c878dda7fd38ab298f/eng/pipelines/templates/stages/vmr-build.yml#L13-L20 We might not need to specify scope: lite in repo pipeline.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

Loading