Fix: Unsupported maccatalyst attribute is getting applied to child attributes but not accounted parent child attributes merge #50334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tributes but not accounted parent child attributes merge
…t can be handled same as other platforms
|
CC @buyaa-n |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where unsupported MacCatalyst attributes applied to child methods were not properly accounted for when merging with parent attributes. The issue occurred because iOS implicitly supports MacCatalyst, but when [UnsupportedOSPlatform("maccatalyst")] is explicitly added to remove this implicit support, the merge logic wasn't preserving this unsupported status.
- Fixed merge logic to properly handle unsupported platform attributes during parent-child attribute merging
- Added condition to check if attributes are set before determining deny list status
- Restructured conditional logic for better handling of supported version boundaries
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PlatformCompatibilityAnalyzer.cs | Fixed merge logic for platform attributes and updated deny list condition |
| PlatformCompatibilityAnalyzerTests.cs | Added comprehensive test cases to verify the fix works correctly |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
...is.NetAnalyzers/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs
Outdated
Show resolved
Hide resolved
ViktorHofer
reviewed
Aug 18, 2025
....UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
…alysis.NetAnalyzers.UnitTests/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzerTests.cs Co-authored-by: Viktor Hofer <[email protected]>
|
@ViktorHofer is anything else needed here to get it approved and merged? |
…ysis.NetAnalyzers/Microsoft.NetCore.Analyzers/InteropServices/PlatformCompatibilityAnalyzer.cs Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an API supported on IOS it also supported by maccatalyst as they are related. To remove implicit maccatalyst support one need to add
[UnsupportedOSPlatform (""maccatalyst"")]to the[SupportedOSPlatform (""ios"")]The
[UnsupportedOSPlatform (""maccatalyst"")]applied to the immediate (child) attributes list and removed the implicit maccatalyst support but when child attributes are merged to the parent attributes list this is not accounted and merged list will keep the implicit maccatalyst support. The PR fixes this bug.Fixes #50337
This is a re-creation of this pull request from dotnet/roslyn-analyzers: dotnet/roslyn-analyzers#7644