Skip to content

Unskip compose test cases #50052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Unskip compose test cases #50052

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7100713
Unskip compose test cases
Aug 5, 2025
f651213
testing output
Aug 6, 2025
f337467
Merge branch 'main' into Simon/Unskip_compose_testcases
SimonZhao888 Aug 12, 2025
f77b123
Merge branch 'main' into Simon/Unskip_compose_testcases
SimonZhao888 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions test/Microsoft.NET.Publish.Tests/GivenThatWeWantToStoreAProjectWithDependencies.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public GivenThatWeWantToStoreAProjectWithDependencies(ITestOutputHelper log) : b
{
}

[Fact(Skip="https://github.com/dotnet/sdk/issues/49900")]
[Fact]
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When unskipping tests, ensure the underlying issue referenced in the Skip parameter (#49900) has been resolved. Consider verifying that these tests pass consistently before removing the Skip attribute.

Copilot generated this review using guidance from repository custom instructions.

public void compose_dependencies()
{
TestAsset simpleDependenciesAsset = _testAssetsManager
Expand All @@ -76,12 +76,20 @@ public void compose_dependencies()
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.Core.dll",
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.dll",
"fluentassertions.json/4.12.0/lib/netstandard1.3/FluentAssertions.Json.dll"
};
};

Console.WriteLine("Files on disk:");
foreach (var file in storeDirectory.GetFiles("*", SearchOption.AllDirectories))
{
// Convert to relative path with forward slashes to match expected format
string relativePath = file.FullName.Substring(storeDirectory.FullName.Length + 1).Replace('\\', '/');
Console.WriteLine(relativePath);
}

storeDirectory.Should().OnlyHaveFiles(files_on_disk);
}

[Fact(Skip="https://github.com/dotnet/sdk/issues/49900")]
[Fact]
public void compose_dependencies_noopt()
{
TestAsset simpleDependenciesAsset = _testAssetsManager
Expand Down Expand Up @@ -119,12 +127,20 @@ public void compose_dependencies_noopt()
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.Core.dll",
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.dll",
"fluentassertions.json/4.12.0/lib/netstandard1.3/FluentAssertions.Json.dll"
};
};

Console.WriteLine("Files on disk:");
foreach (var file in storeDirectory.GetFiles("*", SearchOption.AllDirectories))
{
// Convert to relative path with forward slashes to match expected format
string relativePath = file.FullName.Substring(storeDirectory.FullName.Length + 1).Replace('\\', '/');
Console.WriteLine(relativePath);
}

storeDirectory.Should().OnlyHaveFiles(files_on_disk);
}

[Fact(Skip="https://github.com/dotnet/sdk/issues/49900")]
[Fact]
public void compose_multifile()
{
TestAsset simpleDependenciesAsset = _testAssetsManager
Expand Down Expand Up @@ -156,7 +172,15 @@ public void compose_multifile()
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.Core.dll",
"fluentassertions/4.12.0/lib/netstandard1.3/FluentAssertions.dll",
"fluentassertions.json/4.12.0/lib/netstandard1.3/FluentAssertions.Json.dll",
};
};

Console.WriteLine("Files on disk:");
foreach (var file in storeDirectory.GetFiles("*", SearchOption.AllDirectories))
{
// Convert to relative path with forward slashes to match expected format
string relativePath = file.FullName.Substring(storeDirectory.FullName.Length + 1).Replace('\\', '/');
Console.WriteLine(relativePath);
}

storeDirectory.Should().OnlyHaveFiles(files_on_disk);

Expand Down
Loading