Allow skipping project fallback with file-based run #49808
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a --file option to the dotnet run command, allowing users to explicitly specify a file-based app to run and skip project fallback behavior. This addresses GitHub issue #49790 by providing a way to run file-based apps even when a project exists in the current directory.
Key changes include:
- Added new
--fileoption to the run command with appropriate validation - Updated file-based app execution logic to use the new option format internally
- Added comprehensive test coverage for the new functionality
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/Run/RunCommandParser.cs | Adds the new --file option definition |
| src/Cli/dotnet/Commands/Run/RunCommand.cs | Implements logic for handling the --file option and validation |
| src/Cli/dotnet/Program.cs | Updates file-based app parsing to use --file option format |
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Adds localization strings for the new option |
| test/dotnet.Tests/CommandTests/Run/RunFileTests.cs | Adds test coverage for the new functionality |
| documentation/general/dotnet-run-file.md | Updates documentation to reflect the new option |
| Multiple .xlf files | Adds localization entries for all supported languages |
| Multiple completion snapshot files | Updates shell completion scripts |
|
@RikkiGibson @jaredpar for reviews, thanks |
|
@RikkiGibson @333fred for reviews, thanks |
| .Should().Pass() | ||
| .And.HaveStdOutContaining(""" | ||
| Hello from Program | ||
| """); |
There was a problem hiding this comment.
So the fact that there is no "echo args" in the output means we ran the file rather than running the project? Is that right?
There was a problem hiding this comment.
The project cannot even run, it has no source files (only a project file). If it could run, it should print Hello from App instead of Hello from Program. And yes, there would be also echo args.
Resolves #49790.