make SdkResolver try to locate the dotnet host closest to the resolved SDK #49772
+213
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
approved these changes
Jul 14, 2025
|
definitely - there are some existing that @surayya-MS already had as part of this initial implementation that would be good to expand on |
baronfel
force-pushed
the
sdk-resolver-dotnet-exe-relative-to-resolved-sdk
branch
2 times, most recently
from
3c260af to
efa2005
Compare
|
Alright - I've added a test that covers the new scenario! This is good to merge as soon as the dang containerbased linux leg stops hanging. |
baronfel
force-pushed
the
sdk-resolver-dotnet-exe-relative-to-resolved-sdk
branch
from
efa2005 to
402a092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49363
Before we always returned the dotnet.exe from PATH, but especially in cases where the user has set a local path in global.json this may not be correct. To help ensure better host alignment we try to prefer hosts from within the resolved sdk root's parent directory heirarchy.