Various SDK build fixes within VS #49748
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NoWarn for NU5039. Added -ExecutionPolicy Bypass for calls to PowerShell. Added blank GetTargetPath to sdk-tasks.csproj. Other minor cleanup.
There was a problem hiding this comment.
Pull Request Overview
Addresses several build and tooling issues when performing a full rebuild in Visual Studio by renaming project files for VS compatibility, suppressing new NuGet warnings, ensuring PowerShell scripts run under restrictive execution policies, and adding a helper script for runtime copying.
- Rename
manifest-packages.proj→manifest-packages.csprojand update all references. - Suppress additional NuGet warnings (
NU5039) and add-ExecutionPolicy Bypassto MSI-generation scripts. - Introduce an empty
GetTargetPathMSBuild target and add a newcopy-runtime.ps1script to copy built runtimes into Program Files.
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/Microsoft.DotNet.PackageValidation.Tests/*.csproj | Added Microsoft.CodeAnalysis.CSharp package reference |
| test/Directory.Build.props | Combined and clarified NoWarn entries for NU5125/NU5123 |
| src/Workloads/VSInsertion/workloads.csproj | Updated <ProjectReference> to point at .csproj file |
| src/Workloads/Manifests/Directory.Build.props | Added NU5039 to NoWarn |
| src/Tasks/sdk-tasks/sdk-tasks.csproj | Added stub <Target Name="GetTargetPath" /> |
| src/Layout/redist/targets/GenerateMSIs.targets | Added -ExecutionPolicy Bypass to PowerShell <Exec> commands |
| src/Layout/redist/targets/BundledManifests.targets | Updated MSBuild project path to .csproj |
| src/Layout/redist/redist.csproj | Updated <ProjectReference> to .csproj |
| sdk.slnx | Updated solution entry for manifest-packages.csproj |
| eng/copy-runtime.ps1 | New admin-run PowerShell script to copy built runtime into Program Files |
| Directory.Build.props | Added NU5039 to root NoWarn |
| .vsconfig | New Visual Studio configuration file |
MiYanni
commented
Jul 16, 2025
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="$(RepoRoot)src\Compatibility\ApiCompat\Microsoft.DotNet.PackageValidation\Microsoft.DotNet.PackageValidation.csproj" /> | ||
| <ProjectReference Include="..\Microsoft.NET.TestFramework\Microsoft.NET.TestFramework.csproj" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" /> |
There was a problem hiding this comment.
I just moved this into the ItemGroup that is for PackageReferences. Not sure why it was here to begin with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on: #49746
Summary
After trying to do "Rebuild All" within VS for the repo, I ran into a bunch of problems. This should address some of them.
Various fixes:
manifest-packages.projtomanifest-packages.csprojfor VS compatibilityNU5039to NoWarn since we get this warning for all the packages we make-ExecutionPolicy Bypasssince you cannot build the redist project if your PowerShell is set to Restricted ExecutionPolicy (default on new Windows installs)GetTargetPathtarget to sdk-tasks.csproj as it was complaining about it when trying to rebuild