Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both inputs are equal here so if one of them is non ASCII, then the other one is too (idea taken from @BrennanConroy)
ASM diff: https://www.diffchecker.com/hdGIxueW
#87141 have not introduced the regression reported in #88670, but it has changed... the code alignment.
This PR improves the perf for the mentioned benchmark by 5%.
The other benchmark is back to it's previous state:
So it should be safe to assume that this PR is going to fix #88670