Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some errors trying to build runtime with a preview6 SDK due to
win-arm
RIDs in various projects. This scrubs most references towin-arm
that I found, with a few exceptions.I wasn't sure if it's safe to remove these. I think it should be ok, because we shouldn't need to fall back from
win-arm
assets if they are entirely unsupported, but I've left these references for now:runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.json
Lines 4264 to 4268 in f4ef5c8
runtime/src/libraries/Microsoft.NETCore.Platforms/src/runtime.compatibility.json
Lines 11082 to 11087 in f4ef5c8
I assume these should stay as-is since they are .net6/.net7 manifests:
runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest/WorkloadManifest.json.in
Lines 475 to 481 in f4ef5c8
runtime/src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.net6.Manifest/WorkloadManifest.json.in
Lines 444 to 450 in f4ef5c8