Address Metrics APIs issues #86740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tarekgh merged 6 commits into dotnet:main from tarekgh:MetricsAPIsFollowUpDelta

May 26, 2023

Member

tarekgh commented May 25, 2023

The changes here addressing the following issues:

To ensure the factory owns the meter's lifetime, the factory's created meter should have a no-op disposal operation. [Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592
Ignore the order of the tags when caching instruments and meters to make them order insensitive. [Tracking] Decide if the tags order matter when creating meter or instrument #86614
Remove the scope parameter from the IMeterFactory extension Create method.
Throw exception when the user calls IMeterFactory passing MeterOptions with non-null scope and not equal to IMeterFactory instance. DefaultMeterFactory.Create and MeterOptions.Scope #86684
Moved the IMeterFactory Create method from Microsoft.Extensions.Diagnostics to Microsoft.Extensions.Diagnostics.Abstraction library.
Remove the added dependency on the System.Linq in the system.Diagnostics.DiagnosticSource library.


          Address Metrics APIs issues

d251229

ghost added needs-area-label new-api-needs-documentation labels

ghost commented May 25, 2023

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost assigned tarekgh

tarekgh requested a review from noahfalk

May 25, 2023 01:32

tarekgh added area-System.Diagnostics.Metric and removed needs-area-label labels

tarekgh added this to the 8.0.0 milestone

stephentoub reviewed

View reviewed changes

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated

@@ @@ -7,62 +7,241 @@ namespace System.Diagnostics @@
               {
                   internal static class DiagnosticsHelper
                   {
-                      internal static bool CompareTags(IEnumerable<KeyValuePair<string, object?>>? tags1, IEnumerable<KeyValuePair<string, object?>>? tags2)
+                      // This is similar to System.Linq ToArray. We are not using System.Linq here to avoid the dependency.

Member

stephentoub May 25, 2023

Why is the dependency problematic?

Member Author

tarekgh May 25, 2023

The auto-instrumentation can force loading higher version of System.Diagnostics.DiagnosticSource than the version of the one that app built with. Increasing the dependency of System.Diagnostics.DiagnosticSource can increase the risk of breaking the auto-instrumentation. Here is some related issue talking about similar thing #42244

stephentoub reviewed

View reviewed changes

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

...ibraries/Microsoft.Extensions.Diagnostics.Abstractions/src/Metrics/MeterFactoryExtensions.cs Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved


          Address the feedback

f477374

Member Author

tarekgh commented May 25, 2023

build-analysis bot mentioned this pull request

Failed USB connection via port 54050, error 61, in tvOS arm64 Release AllSubsets_Mono #82637

Open


          Fix the correct thrown exception name.

69e5efe

noahfalk approved these changes

View reviewed changes

Member

noahfalk left a comment

Mostly looked good. I think I spotted two bugs and a few other suggestions inline.

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

src/libraries/Microsoft.Extensions.Diagnostics/src/Metrics/DefaultMeterFactory.cs Show resolved Hide resolved

src/libraries/Microsoft.Extensions.Diagnostics/tests/MetricsTests.cs Show resolved Hide resolved

src/libraries/Common/src/System/Diagnostics/DiagnosticsHelper.cs Outdated Show resolved Hide resolved

tarekgh added 3 commits

May 26, 2023 11:00


          Address the feedback

ea3b81d


          Address the feedback

587408c


          remove empty line

14e3331

tarekgh merged commit 813a46d into dotnet:main

tarekgh deleted the MetricsAPIsFollowUpDelta branch

May 26, 2023 23:34

This was referenced May 26, 2023

DefaultMeterFactory.Create and MeterOptions.Scope #86684

Closed

[Tracking] Decide if the tags order matter when creating meter or instrument #86614

Closed

[Tracking] Figure out how we should handle the disposing of the meters created from meter factory #86592

Closed

IDisposable mentioned this pull request

Cleanup BitMapper sizeof type #86881

Merged

tarekgh mentioned this pull request

What's new in .NET 8 Preview 5 [WIP] dotnet/core#8436

Closed

3 tasks

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Diagnostics.Metric new-api-needs-documentation