Fix Helix command lines error code handling #85622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HelixCommandLines` group must not call `exit` on the script or the HelixPostCommands and potentially other injected commands will not run. Instead, figure out what the exit code should be, and set it properly (as `ERRORLEVEL` on Windows or `$?` on non-Windows). Fixes dotnet#85621
ghost
added
the
|
Tagging subscribers to this area: @hoyosjs Issue DetailsThe Instead, figure out what the exit code should be, and set it properly (as Fixes #85621
|
jkoritzinsky
approved these changes
May 2, 2023
|
I verified that Linux, Windows, and Mac test runs all ran script lines after the XUnitLogChecker. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HelixCommandLinesgroup must not callexiton the script or the HelixPostCommands and potentially other injected commands will not run.Instead, figure out what the exit code should be, and set it properly (as
ERRORLEVELon Windows or$?on non-Windows).Fixes #85621