[mono] Add back OP_XOP_OVR_X_X for arm64 #85401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also add missing intrinsic attributes. This addresses feedback from dotnet#85390
vargaz
approved these changes
Apr 26, 2023
vargaz
reviewed
Apr 26, 2023
| @@ -8704,12 +8710,6 @@ MONO_RESTORE_WARNING | |||
| values [ins->dreg] = call_intrins (ctx, id, args, ""); | |||
| break; | |||
| } | |||
| case OP_XOP_OVR_X_X: { | |||
| IntrinsicId iid = (IntrinsicId) ins->inst_c0; | |||
There was a problem hiding this comment.
These probably can be moved outside the ifdefs.
There was a problem hiding this comment.
I found it. They were Arm64 only before. I think that it is better to keep it under #if defined(TARGET_ARM64) || defined(TARGET_WASM), as it is only used by those two platforms. If we need to use it on other platforms, we could move it out later.
|
Thanks, this fixes the issues I saw on iOS. Please backport to release/8.0-preview4 |
|
/backport to release/8.0-preview4 |
|
Started backporting to release/8.0-preview4: https://github.com/dotnet/runtime/actions/runs/4811230237 |
fanyang-mono
approved these changes
Apr 26, 2023
This was referenced Apr 26, 2023
|
The failures are unrelated |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also add missing intrinsic attributes.
This addresses feedback from #85303
Fixes #85345