Skip to content

Fix clang tool downloads #84799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

BruceForstall
Copy link
Contributor

  1. Make downloading more robust by failing the download script if there is a download error.
  2. Map macOS and Ubuntu RIDs to RIDs that we know have versions to download. This same logic is in the dotnet/jitutils bootstrap.sh script. We don't want to upload versions for every RID since they are all compatible. This makes the script robust to people running on new releases.
  3. Add more logging.

Fixes #84780

1. Make downloading more robust by failing the download script if
there is a download error.
2. Map macOS and Ubuntu RIDs to RIDs that we know have versions to
download. This same logic is in the dotnet/jitutils bootstrap.sh script.
We don't want to upload versions for every RID since they are all
compatible. This makes the script robust to people running on new
releases.
3. Add more logging.
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Make downloading more robust by failing the download script if there is a download error.
  2. Map macOS and Ubuntu RIDs to RIDs that we know have versions to download. This same logic is in the dotnet/jitutils bootstrap.sh script. We don't want to upload versions for every RID since they are all compatible. This makes the script robust to people running on new releases.
  3. Add more logging.

Fixes #84780

Author: BruceForstall
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@BruceForstall
Copy link
Contributor Author

@kunalspathak PTAL
cc @dotnet/jit-contrib

@jkoritzinsky
Copy link
Member

It shouldn't be part of this PR, but can we file an issue to update the Clang tools to be the same version as the official compilers we have on our build images? Right now we're still using clang-format and clang-lint from 3.9, which is significantly out of date compared to our default build tools (clang 9 moving to 12 or 14).

@SingleAccretion
Copy link
Contributor

#59545

@BruceForstall
Copy link
Contributor Author

The formatting jobs were skipped since this change doesn't include a JIT change. I'm going to merge it anyway (since there's an active CI break) and will test/watch it once merged.

@BruceForstall
Copy link
Contributor Author

Apparently I can't merge (prior to CI jobs running/passing?)

with a message:

Required statuses must pass before merging
All required [statuses](https://docs.github.com/rest/commits/statuses) and check runs on this pull request must run successfully to enable automatic merging.

Is this a recent change? @jkotas @agocke ?

@jakobbotsch
Copy link
Member

@BruceForstall Might be the license/cla check that seems to be stuck?

@BruceForstall
Copy link
Contributor Author

Guess I'll try close/reopen to see if that fixes the license bot.

@BruceForstall BruceForstall reopened this Apr 13, 2023
@BruceForstall BruceForstall merged commit af775c9 into dotnet:main Apr 13, 2023
@BruceForstall BruceForstall deleted the FixJitFormat branch April 13, 2023 20:49
@jkoritzinsky
Copy link
Member

jkoritzinsky commented Apr 13, 2023

#59545

I honestly forgot we had already opened an issue on that.

@BruceForstall
Copy link
Contributor Author

Well, this didn't work because the RID changed to linux-x64.

@BruceForstall
Copy link
Contributor Author

But at least the failure was more explicit

@BruceForstall
Copy link
Contributor Author

I created a new Azure Storage location with the 'linux-x64' RID and copied the existing ubuntu-18.04-x64 binaries into it.

@ghost ghost locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jitformat failing on linux x64
6 participants