-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix clang tool downloads #84799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang tool downloads #84799
Conversation
1. Make downloading more robust by failing the download script if there is a download error. 2. Map macOS and Ubuntu RIDs to RIDs that we know have versions to download. This same logic is in the dotnet/jitutils bootstrap.sh script. We don't want to upload versions for every RID since they are all compatible. This makes the script robust to people running on new releases. 3. Add more logging.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details
Fixes #84780
|
@kunalspathak PTAL |
It shouldn't be part of this PR, but can we file an issue to update the Clang tools to be the same version as the official compilers we have on our build images? Right now we're still using clang-format and clang-lint from 3.9, which is significantly out of date compared to our default build tools (clang 9 moving to 12 or 14). |
The formatting jobs were skipped since this change doesn't include a JIT change. I'm going to merge it anyway (since there's an active CI break) and will test/watch it once merged. |
Apparently I can't merge (prior to CI jobs running/passing?) with a message:
|
@BruceForstall Might be the license/cla check that seems to be stuck? |
Guess I'll try close/reopen to see if that fixes the license bot. |
I honestly forgot we had already opened an issue on that. |
Well, this didn't work because the RID changed to |
But at least the failure was more explicit |
I created a new Azure Storage location with the 'linux-x64' RID and copied the existing ubuntu-18.04-x64 binaries into it. |
Fixes #84780