Skip to content

Always set GTF_GLOB_REF on block indirs #84731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Always set GTF_GLOB_REF on block indirs #84731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/coreclr/jit/compiler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,16 +1196,7 @@ inline GenTreeBlk* Compiler::gtNewBlkIndir(ClassLayout* layout, GenTree* addr, G
blkNode->gtFlags |= indirFlags;
blkNode->SetIndirExceptionFlags(this);

// TODO-Bug: this method does not have enough information to make this determination.
// The local may end up (or already is) address-exposed.
if (addr->OperIs(GT_LCL_ADDR))
{
if (lvaIsImplicitByRefLocal(addr->AsLclVarCommon()->GetLclNum()))
{
blkNode->gtFlags |= GTF_GLOB_REF;
}
}
else
if ((indirFlags & GTF_IND_INVARIANT) == 0)
{
blkNode->gtFlags |= GTF_GLOB_REF;
}
Expand Down