-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix crash in fixer on certain invalid patterns #80007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsFix #80004
|
Failure is known and not relevant. |
src/libraries/System.Text.RegularExpressions/gen/UpgradeToGeneratedRegexCodeFixer.cs
Show resolved
Hide resolved
...System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs
Outdated
Show resolved
Hide resolved
of the failures both WASM https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-80007-merge-1b7fbe7a837c425684/normal-System.Runtime.Tests/1/console.3b695942.log?helixlogtype=result is another instance of #79874 the other is a timeout https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-80007-merge-351a8f2b805347769a/WasmTestOnBrowser-System.Runtime.Tests/1/console.708fc41e.log?helixlogtype=result
this is not relevant to this change as none of this code uses the regex generator or runs the regex tests. |
...System.Text.RegularExpressions/tests/FunctionalTests/UpgradeToGeneratedRegexAnalyzerTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
src/libraries/System.Text.RegularExpressions/gen/UpgradeToGeneratedRegexCodeFixer.cs
Outdated
Show resolved
Hide resolved
…ratedRegexCodeFixer.cs
Fix #80004
Edit: actually several. I see no reason why double backslashes are in the strings, they appear literally in the exception messages. Fixed them all.