[release/7.0] [mono][aot] Fixed decompose_flag propagation issues #79855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
ghost
added
the
vargaz
approved these changes
Dec 20, 2022
|
@jandupej please fill in the template and email tactics |
He's validating manually and will update the text, email later. Might not happen till after the holidays, so removing the tags for now |
|
@SamMonoRT @jandupej friendly reminder to fill out the template / add |
|
Build failures are unrelated to this PR. |
|
Approved via email. Marking as servicing-approved cc @carlossanlop |
SamMonoRT
added
Servicing-approved
|
Thanks for the ping, @SamMonoRT Approved by Tactics (7.0.3). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #79849 to release/7.0
It has been reported in 79710 that Mono AOT can fail when compiling an assembly that contains a generic class with a method that returns
Typeand has a conditional structure./cc @jandupej
Customer Impact
This PR fixes the issue and allows successful builds of such assemblies.
Testing
We do not have a CI pipeline for this case. The issue can be replicated by building Mono for Android x64 and trying to compile the example specified in the issue 79710. AOT compilation will fail as described in the issue. AOT compilation will succeed when the fix is applied.
Risk
Low. This PR does not add features, only fixes a basic block flag propagation issue that causes the bug. Very little code is touched.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.