[release/7.0] Allow interop resolvers to return self handle #78779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
ghost
added
the
|
/azp run runtime-android |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
lambdageek
added
Servicing-approved
|
Approved by tactics in email |
|
Only things left are a code review sign off from @vargaz or @lambdageek or @thaystg, and verifying the CI results when they're done. |
|
/azp run runtime-androidemulator |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
lambdageek
approved these changes
Nov 23, 2022
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Any concerns about the CI failures, @lambdageek? |
|
failures look unrelated: some hardware flakiness |
|
Branding has been done. Milestone is 7.0.2. Signed-off by area owners. Approved by Tactics. No OOB package authoring changes needed. CI failures unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #78004 to release/7.0
/cc @lambdageek @am11
(Note this an update of #78018 which we had to revert because it broke on Android)
Customer Impact
Customers using the new
GetMainProgramHandleAPI to create custom NativeLibrary resolvers in mobile apps are unable to resolve statically linked symbols in their apps.Testing
New CI test, including Android
Risk
Low
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.