-
Notifications
You must be signed in to change notification settings - Fork 5k
Use IndexOfAnyInRange in StripBidiControlCharacters #78658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IndexOfAnyInRange in StripBidiControlCharacters #78658
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThis method is called on the host when creating a Saw this while looking for cases where we can use
|
Do you plan to look for opportunities in aspnetcore? If not it might be worth opening a suggestion for someone to do that. |
There are multiple places aspnetcore can/should end up using the new API, e.g. dotnet/aspnetcore#33776 (comment) |
@gfoidl had a PR in aspnetcore (dotnet/aspnetcore#44041) that was closed in favour of waiting for these APIs. I can take a look at those cases as well if he doesn't beat me to it, but I imagine it's gonna take a little bit for the runtime changes to flow into that repo anyway. |
@gfoidl do you plan to have a run at aspnetcore cases now this marvelous API is available? |
Yep, that's on my todo-list for the next days (when the APIs is "flowed" to aspnet). |
This method is called on the host when creating a
Uri
.The 99.9% case is that there will be no such characters, so we can let
IndexOfAnyInRange
quickly scan through the input.Saw this while looking for cases where we can use
IndexOfAnyValues
(#78204).