[release/7.0][wasm] SIMD related build fixes #75042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
ghost
assigned 
radical
changed the title
$(WasmSIMD) to $(WasmEnableSIMD)
radical
force-pushed
the
fix-wbt-simd
branch
from
e664f26 to
15a262e
Compare
radical
changed the title
$(WasmSIMD) to $(WasmEnableSIMD)
radekdoulik
reviewed
Sep 5, 2022
| @@ -66,7 +66,7 @@ | |||
| Defaults to false. | |||
| - $(WasmAotProfilePath) - Path to an AOT profile file. | |||
| - $(WasmExceptionHandling) - Enable support for the WASM Exception Handling feature. | |||
| - $(WasmSIMD) - Enable support for the WASM SIMD feature. | |||
| - $(WasmEnableSIMD) - Enable support for the WASM SIMD feature. | |||
There was a problem hiding this comment.
I wanted to keep it similar to other feature props, like the WasmExceptionHandling above. Shouldn't we then change that too?
radekdoulik
approved these changes
Sep 5, 2022
radical
changed the title
|
Ping @marek-safar, need an approval. Edit: Confirmed, the CI failures are unrelated. They are #75164 and #75005 . |
marek-safar
approved these changes
Sep 6, 2022
This was referenced Sep 6, 2022
|
@radical there's a merge conflict. Can you please address it? |
|
This is ready for merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(WasmSIMD)->$(WasmEnableSIMD)