Skip to content

Use ConfigureAwait(false) #74982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

Use ConfigureAwait(false) #74982

merged 1 commit into from
Sep 5, 2022

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Sep 2, 2022 •
edited
Loading

#74825 (review)

I don't think we need to run on the same thread.

Cc @tlakollo

@MichalStrehovsky
Use ConfigureAwait(true)
8cf4947 
dotnet#74825 (review)

I don't think we need to run on the same thread.
@ghost ghost assigned MichalStrehovsky Sep 2, 2022
@MichalStrehovsky MichalStrehovsky changed the title Use ConfigureAwait(true) Use ConfigureAwait(false) Sep 2, 2022
stephentoub
stephentoub approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@MichalStrehovsky MichalStrehovsky merged commit 4940059 into dotnet:main Sep 5, 2022
@MichalStrehovsky MichalStrehovsky deleted the configureawait branch September 5, 2022 00:53
@MichalStrehovsky
Copy link
Member Author

OSX failure is #75005.

@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@tlakollo tlakollo tlakollo approved these changes

@davidwrighton davidwrighton Awaiting requested review from davidwrighton

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalStrehovsky @stephentoub @tlakollo