Skip to content

Expand NativeAOT testing platforms #73546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2022
Merged

Expand NativeAOT testing platforms #73546

merged 4 commits into from
Aug 11, 2022

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Aug 8, 2022 •
edited
Loading

  • We don't officially support x64 Mac because it would look dumb if we don't support ARM64. I would still like to see us testing it to prevent regressions.
  • We should ideally support MUSL-based Linux officially (let's see how close we're based on CI).

@ghost ghost assigned MichalStrehovsky Aug 8, 2022
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Aug 8, 2022
Closed
Open
Closed
Closed
@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky MichalStrehovsky mentioned this pull request Aug 10, 2022
Closed
@LakshanF
Copy link
Contributor

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF
Copy link
Contributor

Retrying since the changes that caused dotnet/linker#2963 was reverted

LakshanF
LakshanF approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no OSX testing in this, right?

@MichalStrehovsky
Copy link
Member Author

I reverted the OSX part because it was a crashfest and nobody is going to look at that in the 7.0 timeframe: #73299 (comment)

@MichalStrehovsky MichalStrehovsky merged commit e65f224 into main Aug 11, 2022
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-1 branch August 11, 2022 02:42
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichalStrehovsky @LakshanF