Skip to content

[libs][mono] Enable diagnostics_tracing runtime component in Android build #72955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 27, 2022

Fixes #50926

@mdh1418 mdh1418 requested a review from steveisok July 27, 2022 18:37
@ghost ghost assigned mdh1418 Jul 27, 2022
@ghost
Copy link

ghost commented Jul 27, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #50926

Author: mdh1418
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

…build and reenable System.Diagnostics.Tracing
@mdh1418
Copy link
Member Author

mdh1418 commented Jul 27, 2022

This will cause merge conflicts with #72394 due to both touching tests.mobile.targets, but if desired, we could block this until that PR is merged and only remove the test skip and extend the diagnostics_tracing condition.

@mdh1418
Copy link
Member Author

mdh1418 commented Jul 27, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go first. It'll be easier to merge

@mdh1418
Copy link
Member Author

mdh1418 commented Jul 28, 2022

The failures are unrelated for non-Android lanes. The android specific failures on runtime-extra-platforms have been disabled by #72948

@mdh1418 mdh1418 merged commit 0cd410b into dotnet:main Jul 28, 2022
@mdh1418 mdh1418 deleted the reenable_android_system_diagnostics_tracing branch July 28, 2022 14:34
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Diagnostics.Tracing.Tests Fails on Android
2 participants