[wasm][debugger][tests] Fix crash in EvaluateOnCallFrameTests on CI
#69073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `TestHarnessProxy`, we recently started adding proxy instances to a static table, to enable getting the correct exit state from the client. But the instances were not removed from the table, which prevented the GC from collecting them. This manifests as the test process crashing on systems with 8GB of memory, when running `EvaluateOnCallFrameTests`. It would end up getting to a resident size of 2.2-2.7G, and then crash after about 30 tests. With these changes, the proxy gets collected, and the resident memory hovers around 500M. Future work: this will change once we start using the upcoming app host work, and thus moving the proxy to a separate process via `dotnet run --debug`.
ghost
assigned 
|
Tagging subscribers to this area: @thaystg Issue DetailsIn This manifests as the test process crashing on systems with 8GB of Future work: this will change once we start using the upcoming app host
|
radical
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIn This manifests as the test process crashing on systems with 8GB of Future work: this will change once we start using the upcoming app host
|
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The wasm/library test failures are #69085 . |
lewing
approved these changes
May 10, 2022
|
The coreclr failures seem intermittent. And are unrelated to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TestHarnessProxy, we recently started adding proxy instances to astatic table, to enable getting the correct exit state from the client.
But the instances were not removed from the table, which prevented the
GC from collecting them.
This manifests as the test process crashing on systems with 8GB of
memory, when running
EvaluateOnCallFrameTests. It would end up gettingto a resident size of 2.2-2.7G, and then crash after about 30 tests. With these changes, the
proxy gets collected, and the resident memory hovers around 500M.
Future work: this will change once we start using the upcoming app host
work, and thus moving the proxy to a separate process via
dotnet run --debug.