Fix Docs_Examples_ValidateEmail test #68294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent change around timeouts appears to have made the timeout used in this test more accurate, which makes it more likely to fire, which is tripping up CI on slower machines. There's no need for a timeout in this test, though; just delete it.
|
Tagging subscribers to this area: @dotnet/area-system-text-regularexpressions Issue DetailsThe recent change around timeouts appears to have made the timeout used in this test more accurate, which makes it more likely to fire, which is tripping up CI on slower machines. There's no need for a timeout in this test, though; just delete it. Fixes #68286
|
elinor-fung
approved these changes
Apr 20, 2022
directhex
pushed a commit
to directhex/runtime
that referenced
this pull request
Apr 21, 2022
The recent change around timeouts appears to have made the timeout used in this test more accurate, which makes it more likely to fire, which is tripping up CI on slower machines. There's no need for a timeout in this test, though; just delete it.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change around timeouts appears to have made the timeout used in this test more accurate, which makes it more likely to fire, which is tripping up CI on slower machines. There's no need for a timeout in this test, though; just delete it.
Fixes #68286
cc: @elinor-fung, @joperezr