Discard casts when storing normalize-on-load locals #66389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsI noticed this when looking at some regressions when promoting more locals. Turning
|
|
/azp run Antigen, Fuzzlyn |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…ormalize-on-load-writes
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The issue dotnet#35687 was closed in dotnet#59784 and I can confirm the original repro mentioned there no longer reproduces with this test. Fix dotnet#65934
…or-normalize-on-load-writes
…or-normalize-on-load-writes
|
/azp run runtime-coreclr superpmi-asmdiffs |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
cc @dotnet/jit-contrib PTAL @BruceForstall |
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BruceForstall
approved these changes
Apr 14, 2022
|
Test failure was #67878 and the Fuzzlyn failures had issues opened for them/are known. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when looking at some regressions when promoting more locals. Turning
ASG(IND(ADDR(LCL_VAR)), CAST(...))intoASG(LCL_VAR, CAST(...))would regress some cases.