Skip to content

Specify intermediate certificate for ChainTests.BuildInvalidSignatureTwice. #50045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vcsjones
Copy link
Member

@vcsjones vcsjones commented Mar 22, 2021

This test was relying on AIA certificate fetching, or it already being cached, to get the
intermediate certificate. This is not the purpose of this test,
and the fetching appears to have gotten unreliable.

This change uses a different certificate for the test and puts the
intermediate certificate in the extra store so that AIA fetching
is not used.

Closes #48851

…Twice.

This test was relying on AIA certificate fetching to get the
intermediate certificate. This is not the purpose of this test,
and the fetching appears to have gotten unreliable.

This change uses a different certificate for the test and puts the
intermediate certificate in the extra store so that AIA fetching
is not used.
@ghost ghost added the area-System.Security label Mar 22, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

This test was relying on AIA certificate fetching to get the
intermediate certificate. This is not the purpose of this test,
and the fetching appears to have gotten unreliable.

This change uses a different certificate for the test and puts the
intermediate certificate in the extra store so that AIA fetching
is not used.

Closes #48851

Author: vcsjones
Assignees: -
Labels:

area-System.Security

Milestone: -

@stephentoub
Copy link
Member

@vcsjones, mind resolving the conflict? Thanks!

@vcsjones
Copy link
Member Author

vcsjones commented Mar 23, 2021

@stephentoub ha, it looks like #49532 pretty much did the same thing, with a little more changes to help the test pass on Android, so this PR is obsolete. Closing this PR then, but we should close #48851 since it should be fixed by #49532.

@vcsjones vcsjones closed this Mar 23, 2021
@vcsjones vcsjones deleted the 48851-provide-intermediate-cert branch March 23, 2021 13:42
@ghost ghost locked as resolved and limited conversation to collaborators Apr 22, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Security.Cryptography.X509Certificates.Tests.ChainTests.BuildInvalidSignatureTwice
4 participants