-
Notifications
You must be signed in to change notification settings - Fork 5k
Build Threading.Tasks.DataFlow and ComponentModel.Annotations for NetCoreAppCurrent #48667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @safern, @ViktorHofer |
@ViktorHofer and I were just discussing this the other day. There's no requirement to target What benefit are we getting by targeting |
Having to compile cc @vitek-karas |
We don't get the same benefit as .NET Standard and .NET Framework are not annotated, so you don't get data flow analysis on stuff like |
That's a bummer. So long as we have these configurations we should be really careful about them being noticeably different from the package. At the moment we only have code review to catch significant differences. |
src/libraries/System.Threading.Tasks.Dataflow/src/System.Threading.Tasks.Dataflow.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dataflow nullable annotation changes LGTM
Looks like I missed a Not a huge change, but if anyone wants to take another look here. |
Respond to PR feedback
Failures are #1488 |
Fix #48662
This involved fixing a few nullable annotation errors in System.Threading.Tasks.DataFlow.
cc @ericstj