Skip to content

Use async ChangeToken.OnChange overload in FileConfigurationProvider #130492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svick wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Use async ChangeToken.OnChange overload in FileConfigurationProvider #130492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...raries/Microsoft.Extensions.Configuration.FileExtensions/src/FileConfigurationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
using System.IO;
using System.Runtime.ExceptionServices;
using System.Text;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.Extensions.FileProviders;
using Microsoft.Extensions.Primitives;

Expand All @@ -33,9 +33,9 @@ public FileConfigurationProvider(FileConfigurationSource source)
{
_changeTokenRegistration = ChangeToken.OnChange(
() => Source.FileProvider.Watch(Source.Path!),
() =>
async () =>
{
Thread.Sleep(Source.ReloadDelay);
Comment thread
tarekgh marked this conversation as resolved.
await Task.Delay(Source.ReloadDelay).ConfigureAwait(false);
Load(reload: true);
});
Comment on lines 34 to 40

@svick svick Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the synchronous case, the exception is rethrown in whatever the IFileProvider uses for watching. In case it's PhysicalFilesWatcher, the exception is swallowed anyway.

So I don't think this is a problem.

@tarekgh tarekgh Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It holds specifically for PhysicalFilesWatcher (the provider behind  AddJsonFile / AddXmlFile  etc.). A hypothetical custom IFileProvider that invokes token callbacks synchronously and lets exceptions propagate would surface the error in the sync model but not the async one. That is within the async overload's documented contract ("asynchronous exceptions are left unobserved"). I know this is minor issue but is it possible?

}
Expand Down
Loading