[release/10.0] Deny unmasked frame receive for WebSocket Server #123660
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
approved these changes
Jan 27, 2026
Member
MihaZupan
left a comment
MihaZupan
left a comment
There was a problem hiding this comment.
Have we looked at any common WebSocket servers to see if they emit unmasked frames by any chance since that could break .NET clients?
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
This was referenced Jan 27, 2026
Open
karelz
approved these changes
Feb 3, 2026
Member
karelz
left a comment
karelz
left a comment
There was a problem hiding this comment.
RFC compliance, we should fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #123485 to release/10.0
/cc @liveans
Increasing RFC compliance for WebSocket
Customer Impact
RFC compliance
Regression
No
Testing
Manual verification + automated tests
Risk
Low, the change only affects non‑compliant WebSocket clients sending unmasked frames, which is explicitly disallowed by RFC 6455. No behavior change is expected for compliant clients.