-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[browser][coreCLR] enable System.Runtime.Tests on CI as Release build #122980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d3ff07f to
390b5ab
Compare
390b5ab to
46b6bd6
Compare
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request enables System.Runtime.Tests on CI for browser/CoreCLR as a Release build, addressing multiple components to support this functionality.
Key changes include:
- Adding missing function signatures in CoreCLR's interpreter-to-managed call helpers for browser/WASM
- Implementing workarounds for test loading issues and access checks on WASM
- Refactoring JavaScript/TypeScript code to reduce exported symbols and improve modularity by moving FS operations to a centralized location
- Switching CI pipeline configuration from Debug to Release build
- Disabling IL trimming temporarily for CoreCLR on WASM
- Marking failing tests with ActiveIssue attributes to track them systematically
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 23 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tasks/WasmAppBuilder/coreclr/ManagedToNativeGenerator.cs | Adds missing function signature cookies for interpreter-to-managed calls |
| src/native/rollup.config.defines.js | Removes CI build check from isDebug condition to ensure proper debug configuration |
| src/native/libs/Common/JavaScript/types/emscripten.ts | Removes FS_createPath, FS_createDataFile, and addFunction from EmscriptenModule interface |
| src/native/libs/Common/JavaScript/ems-ambient/index.ts | Adds FS object with createPath and createDataFile methods, removes maybeExit |
| src/native/corehost/browserhost/loader/dotnet.d.ts | Removes FS_createPath, FS_createDataFile, and addFunction from EmscriptenModule interface |
| src/native/corehost/browserhost/libBrowserHost.footer.js | Adds AJSDCE_Deps workaround for acorn-optimizer and reformats dependency list |
| src/native/corehost/browserhost/host/host.ts | Updates FS API calls to use ems.FS instead of ems.Module |
| src/native/corehost/browserhost/CMakeLists.txt | Changes BrowserHost-Static from PUBLIC to PRIVATE linking and adds comment markers |
| src/mono/wasm/testassets/WasmBrowserRunMainOnly/WasmBrowserRunMainOnly.csproj | Adds CoreCLR-specific properties for invariant globalization and disables trimming |
| src/mono/browser/test-main.js | Adds timing output to log test execution duration |
| src/mono/browser/build/WasmApp.InTree.props | Adds comment referencing IL trimming issue |
| src/libraries/tests.proj | Restricts browser smoke tests to Mono runtime only |
| src/libraries/pretest.proj | Removes Mono-only restriction from WASM provisioning |
| eng/testing/tests.browser.targets | Adds CoreCLR-specific test support properties and disables trimming |
| eng/pipelines/runtime.yml | Changes build config to Release and adds CoreCLR library tests template |
| eng/pipelines/common/templates/wasm-coreclr-library-tests.yml | New file defining CoreCLR library test pipeline configuration |
| eng/pipelines/common/templates/browser-wasm-coreclr-build-tests.yml | Updates build config from Debug to Release |
| eng/native.wasm.targets | Reduces EmccExportedRuntimeMethod and EmccExportedFunction items |
| src/libraries/Common/tests/WasmTestRunner/WasmTestRunner.cs | Implements workaround for test assembly loading issue |
| src/coreclr/vm/wasm/callhelpers-interp-to-managed.cpp | Adds numerous missing function signatures for WASM interop |
| src/coreclr/interpreter/compiler.cpp | Adds TARGET_WASM conditional to skip EmitCallsiteCallout workaround |
| src/libraries/System.Runtime/tests/System.Runtime.Tests/System/*.cs | Adds ActiveIssue attributes to disable failing tests for Browser+CoreCLR |
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/WeakReferenceTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Runtime/JitInfoTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/GCTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DateTimeTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Attributes.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/DoubleTests.cs
Outdated
Show resolved
Hide resolved
...em.Runtime/tests/System.Runtime.Tests/System/Runtime/CompilerServices/RuntimeFeatureTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Int128Tests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Runtime.Tests/System/HalfTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
CoreCLR
callhelpers-interp-to-managed.cppSystem.Delegate.DelegateConstructresults in exception #121955WasmTestRunner
Emscripten build
AJSDCEBrowserHost-Staticprivate linking tooEmccExportedRuntimeMethodand other exportsCI & MSBuild
runtimepipeline toReleasewasm-coreclr-library-tests.ymlWasmTestLogExitCode,WasmTestAppendElementOnExit,WasmTestExitOnUnhandledErrorfor library tests on CoreCLRSystem.Runtime.Tests
Fixes #120707