[RyuJIT Wasm] Cast Operations Follow Up #122862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

adamperlin merged 33 commits into dotnet:main from adamperlin:adamperlin/ryujit-wasm-cast

Jan 24, 2026

+366 −75

Contributor

adamperlin commented Jan 5, 2026 •

edited

Loading

This PR addresses some review feedback in #122301 and fills in more codegen for casts on Wasm.
Notably:

Casts to and from all int types (byte, short) are now supported with proper sign extension
- Some generic casting code, in particular GenIntCastDesc was moved out of ifdefs and adapted for Wasm to support this. We don't yet support containment of casts in loads (i.e., the GenIntCastDesc::LOAD_* type casts).
float->int casts are implemented using the saturating non-trapping conversion instructions
- This required changing the type of our Wasm opcodes to be 2 bytes instead of 1

kg and others added 10 commits

December 8, 2025 09:26


          Checkpoint

9288c02


          Add unary opcodes

85f2b80


          Checkpoint

7dbe5ff


          Checkpoint

124c8dd


          Checkpoint

eb34147


          Checkpoint

e3d59bc


          Apply JIT format patch

71eb61b


          Update src/coreclr/jit/codegenwasm.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


          Merge branch 'main' of github.com:dotnet/runtime into kg/ryujit-wasm-…

afadd5d

…cast


          Fix some initial review feedback in wasm codegen for casts

83410d9

github-actions bot added the area-CodeGen-coreclr label

adamperlin mentioned this pull request

[RyuJIT Wasm] Initial implementation of cast operations #122301

Open

dotnet-policy-service bot assigned adamperlin

build-analysis bot mentioned this pull request

Unable to pull image from mcr.microsoft.com #117164

Open

am11 added the arch-wasm label

Contributor

dotnet-policy-service bot commented Jan 5, 2026

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.


          Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…

ba132f4

…it-wasm-cast

This was referenced Jan 7, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

[android-arm64] The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#6408

Open

iOS.Device test WorkItemExecutions #122874

Open

adamperlin added 2 commits

January 13, 2026 18:10


          Re-use main genCodeForCast, genIntToIntCast implementation to handle …

f3e9e63

…some more casting cases; Add genFloatToIntCast


          Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…

9b7f09b

…it-wasm-cast

adamperlin commented

View reviewed changes

src/coreclr/jit/codegenlinear.cpp Show resolved Hide resolved

adamperlin commented

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

adamperlin commented

View reviewed changes

src/coreclr/jit/cpp.hint Outdated Show resolved Hide resolved

adamperlin added 2 commits

January 13, 2026 19:02


          Remove helper calls for double->(u)long conversions on Wasm, jit-format

386f93a


          Remove stray print

c88d66b

adamperlin force-pushed the adamperlin/ryujit-wasm-cast branch from 521f043 to c88d66b Compare

January 14, 2026 17:35


          Add unreached() in some cases for casts

0247f91


          Fix missing small int -> long case

4e8ec4a

adamperlin requested review from AndyAyersMS, SingleAccretion and kg

January 14, 2026 19:19


          jit-format

a4ad71a

SingleAccretion reviewed

View reviewed changes

src/coreclr/jit/codegeninterface.h Outdated Show resolved Hide resolved

src/coreclr/jit/codegenlinear.cpp Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

src/coreclr/jit/emitwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/instrswasm.h Outdated Show resolved Hide resolved

src/coreclr/jit/morph.cpp Outdated Show resolved Hide resolved

AndyAyersMS reviewed

View reviewed changes

src/coreclr/jit/instrswasm.h Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

src/coreclr/jit/codegenlinear.cpp Show resolved Hide resolved

src/coreclr/jit/gentree.cpp Outdated Show resolved Hide resolved

adamperlin added 2 commits

January 14, 2026 16:13


          Address some initial review feedback

44c87f4


          Additional review feedback

cc76584

adamperlin force-pushed the adamperlin/ryujit-wasm-cast branch from d86e911 to cc76584 Compare

January 15, 2026 19:52

adamperlin added 4 commits

January 15, 2026 11:58


          Add details to comment for cast operation costing under Wasm

1b1865f


          jit-format

ec11645


          Re-insert some ifdefs instead of moving code location in codegenlinea…

b62b9ba

…r.cpp


          Address more review feedback

beb5049

Contributor Author

adamperlin commented Jan 15, 2026

@dotnet/jit-contrib Initial feedback should be implemented now so this is ready for another review pass!

kg reviewed

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

kg reviewed

View reviewed changes

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

SingleAccretion reviewed

View reviewed changes

src/coreclr/jit/codegenlinear.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Outdated Show resolved Hide resolved

src/coreclr/jit/codegenwasm.cpp Show resolved Hide resolved

src/coreclr/jit/morph.cpp Outdated Show resolved Hide resolved


          Update src/coreclr/jit/codegenwasm.cpp

cfb2ce1

Co-authored-by: SingleAccretion <62474226+SingleAccretion@users.noreply.github.com>

Member

AndyAyersMS commented Jan 22, 2026

@adamperlin can you resolve the merge conflicts when you get a chance?

Seems like this is close?

adamperlin added 4 commits

January 23, 2026 10:08


          Address some additional review feedback

cae1c5f


          Merge branch 'main' of github.com:dotnet/runtime into adamperlin/ryuj…

b20e4d9

…it-wasm-cast


          Remove unnecessary ifdef for load containment in casts (we shouldn't …

a0fce7d

…hit this code yet)


          Merge branch 'adamperlin/ryujit-wasm-cast' of github.com:adamperlin/r…

9b03be5

…untime into adamperlin/ryujit-wasm-cast

Contributor Author

adamperlin commented Jan 23, 2026

@adamperlin can you resolve the merge conflicts when you get a chance?

Seems like this is close?

@AndyAyersMS yes! I've now resolved the merge conflicts and addressed the last bit of feedback. Please feel free to take another look!


          jit-format

fcd500b

AndyAyersMS approved these changes

View reviewed changes

Member

AndyAyersMS left a comment

Indentation is still a bit wonky in instrswasm.h but we can fix that the next time we modify that file.

build-analysis bot mentioned this pull request

Cannot find 'arm64-v8a' device dotnet/dnceng#2284

Open

3 tasks

adamperlin merged commit ef2aefa into dotnet:main

126 of 128 checks passed

dotnet-maestro bot mentioned this pull request

[main] Source code updates from dotnet/runtime dotnet/dotnet#4401

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm area-CodeGen-coreclr