Cleanup some dead paths in EH

[huoyaoyuan]

Also moves ThreadStartException to managed code.

The general question is about where RaiseException is required instead of DispatchManagedException. I played a bit with it in QCall and DispatchManagedException seems to interop directly with C++ EH on Windows. UnwindAndContinueRethrowHelperAfterCatch(nativeRethrow) is intentional, but HandleThreadAbort doesn't look like.

[dotnet-policy-service]

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

[jkotas]

The test failure looks related:

  Starting:    System.Diagnostics.Process.Tests (parallel test collections = on [2 threads], stop on fail = off)
    System.Diagnostics.Tests.ProcessStartInfoTests.TestWindowStyle [SKIP]
      Condition(s) not met: "IsAdmin_IsNotNano_RemoteExecutorIsSupported"
    System.Diagnostics.Tests.ProcessStartInfoTests.Verbs_GetWithExeExtension_ReturnsExpected [SKIP]
      Condition(s) not met: "IsNotWindowsNanoServer"
    System.Diagnostics.Tests.ProcessStartInfoTests.ShellExecute_Nano_Fails_Start [FAIL]
      Assert.Throws() Failure: Exception type was not an exact match
      Expected: typeof(System.Threading.ThreadStartException)
      Actual:   typeof(System.Threading.ThreadStateException)
      ---- System.Threading.ThreadStateException : Thread has not been started.

[jkotas]

Could you please resolve the conflict?

[jkotas]

LGTM, Thanks!

@janvorli Could you please take a look as well?

[janvorli]

I will take a look.

[janvorli]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[janvorli]

LGTM, thank you!

[jkotas]

/azp run runtime-coreclr outerloop

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[jkotas]

/ba-g infrastructure timeout (job running for 11 hours)