Sync area notification subscribers with area-owners.md #122357
+61
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update resourceManagement.yml to match area-owners.md for area-AssemblyLoader-coreclr. The mentionees are now @agocke and @elinor-fung, matching the owners listed in area-owners.md. Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
[WIP] Update area-AssemblyLoader-coreclr in resourceManagement file
Sync area-AssemblyLoader-coreclr notification subscribers with area-owners.md
Dec 9, 2025
agocke
reviewed
Dec 9, 2025
Updated resourceManagement.yml to sync all area label notification subscribers with docs/area-owners.md. Key changes: - area-Host: vitek-karas, agocke, vsadov -> jeffschwMSFT, elinor-fung - area-HostModel: vitek-karas, agocke -> elinor-fung - area-AssemblyLoader-mono: [] -> agocke, elinor-fung - area-CodeGen-coreclr: JulieLeeMSFT, jakobbotsch -> dotnet/jit-contrib - area-GC-coreclr: dotnet/gc -> Maoni0 - area-Infrastructure: dotnet/runtime-infrastructure -> jeffschwMSFT, MichaelSimons - And 27 other areas synced with their documented owners Total: 33 areas updated to match area-owners.md Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
Sync area-AssemblyLoader-coreclr notification subscribers with area-owners.md
Sync all area notification subscribers with area-owners.md
Dec 9, 2025
agocke
reviewed
Dec 9, 2025
Updated resourceManagement.yml to include both the Lead and Owners columns from area-owners.md in notification subscribers, as requested. Previously only included Owners column, now includes Lead + Owners (with Lead first if not already in Owners list). Key examples: - area-Codegen-Intrinsics-mono: [] -> steveisok (Lead only, no owners) - area-Build-mono: akoeplinger -> lewing, akoeplinger (added Lead) - area-Host: jeffschwMSFT, elinor-fung -> agocke, jeffschwMSFT, elinor-fung (added Lead) - area-GC-coreclr: Maoni0 -> agocke, Maoni0 (added Lead) - And 92 other areas updated to include Lead Total: 96 areas updated to include both Lead and Owners Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
Sync all area notification subscribers with area-owners.md
Sync all area notification subscribers with area-owners.md (Lead + Owners)
Dec 10, 2025
agocke
reviewed
Dec 10, 2025
agocke
reviewed
Dec 10, 2025
Updated area-owners.md to correct the Owners for area-GC-coreclr from @Maoni0 to @dotnet/gc. Also updated resourceManagement.yml to match the corrected area-owners.md. This ensures the GC team is notified for area-GC-coreclr issues rather than just an individual. Co-authored-by: agocke <[email protected]>
For areas where jeffhandley is the lead and the owners include dotnet/* teams, removed jeffhandley from the notification subscribers since the team already covers the notification needs. This affects 59 areas including: - area-System.Diagnostics.EventLog: jeffhandley, dotnet/area-system-diagnostics-eventlog -> dotnet/area-system-diagnostics-eventlog - area-System.Buffers: jeffhandley, dotnet/area-system-buffers -> dotnet/area-system-buffers - area-Extensions-* (9 areas) - area-System.* (45 areas) - And other areas where jeffhandley leads teams The dotnet/* teams already include the necessary members for notifications. Co-authored-by: agocke <[email protected]>
agocke
reviewed
Dec 11, 2025
| - mentionUsers: | ||
| mentionees: | ||
| - dotnet/interop-contrib | ||
| - agocke |
Member
There was a problem hiding this comment.
Looks like this is right and area-owners should be updated
Contributor
Author
There was a problem hiding this comment.
Fixed in commit ac7b4df. Updated area-owners.md to include agocke (lead) in the owners column for area-Interop-coreclr.
Member
There was a problem hiding this comment.
I meant, revert these changes and add the deleted names to the md file.
Contributor
Author
There was a problem hiding this comment.
Fixed in commit d0528f3. Reverted area-Interop-coreclr to dotnet/interop-contrib and added agocke, AaronRobinsonMSFT, jkoritzinsky as consultants in area-owners.md.
Changes made: 1. Updated area-Interop-coreclr owners to include agocke (lead) 2. Updated area-System.Runtime.InteropServices owners to include agocke (lead) 3. Updated area-System.Net.Security owners to include karelz (lead) 4. Replaced jaredpar with phil-allen-msft for 4 areas (Microsoft.CSharp, Microsoft.VisualBasic, System.Dynamic.Runtime, System.Linq.Expressions) 5. Updated area-Infrastructure-mono owners to include steveisok (lead) 6. Updated area-Infrastructure owners to include agocke (lead) 7. Updated area-Infrastructure-coreclr to use dotnet/runtime-infrastructure team instead of jeffschwMSFT All changes ensure area-owners.md and resourceManagement.yml are in sync. Co-authored-by: agocke <[email protected]>
agocke
reviewed
Dec 12, 2025
agocke
reviewed
Dec 12, 2025
| - mentionUsers: | ||
| mentionees: | ||
| - dotnet/interop-contrib | ||
| - agocke |
Member
There was a problem hiding this comment.
I meant, revert these changes and add the deleted names to the md file.
Member
|
@copilot please address comments |
…s.md Based on feedback, reverted resourceManagement.yml to original state for several areas and added the deleted names as consultants in area-owners.md instead: 1. area-GC-mono: Reverted to brzvlad, added agocke as consultant in MD 2. area-Infrastructure-mono: Reverted to akoeplinger/matouskozak/simonrozsival, added steveisok/agocke as consultants in MD 3. area-System.Formats.Asn1: Re-added bartonjs/vcsjones (already listed as consultants in MD) 4. area-System.Formats.Cbor: Re-added bartonjs/vcsjones (already listed as consultants in MD) 5. area-System.IO.Hashing: Re-added bartonjs/vcsjones, added as consultants in MD 6. area-System.Net.Security: Reverted to dotnet/ncl + bartonjs/vcsjones, added karelz as consultant in MD 7. area-System.Runtime.InteropServices: Reverted to dotnet/interop-contrib, added agocke/AaronRobinsonMSFT/jkoritzinsky as consultants in MD 8. area-Interop-coreclr: Reverted to dotnet/interop-contrib, added agocke/AaronRobinsonMSFT/jkoritzinsky as consultants in MD 9. area-Infrastructure: Reverted to dotnet/runtime-infrastructure, added jeffschwMSFT/MichaelSimons as consultants in MD This approach keeps the automation with teams while documenting individual experts as consultants. Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
Sync all area notification subscribers with area-owners.md (Lead + Owners)
Sync area notification subscribers with area-owners.md (teams + consultants)
Dec 12, 2025
Changes made per @agocke's feedback: 1. area-System.Runtime.Intrinsics: Added bartonjs and vcsjones to both resourceManagement.yml and area-owners.md 2. area-Infrastructure: Removed jeffschwMSFT from consultants (kept MichaelSimons) 3. area-Infrastructure-mono: Removed consultants section 4. area-Interop-coreclr: Removed consultants section 5. area-System.IO.Hashing: Moved bartonjs and vcsjones from consultants to owners column (before dotnet/area-system-io-hashing) 6. area-System.Net.Security: Moved bartonjs and vcsjones from consultants to owners column (after dotnet/ncl), removed karelz from consultants 7. area-System.Runtime.InteropServices: Removed consultants section All changes ensure proper notification routing while keeping area-owners.md clean and accurate. Co-authored-by: agocke <[email protected]>
Copilot
AI
changed the title
Sync area notification subscribers with area-owners.md (teams + consultants)
Sync area notification subscribers with area-owners.md
Jan 5, 2026
Per @agocke's feedback, added bartonjs and vcsjones to: 1. resourceManagement.yml mentionees for area-System.Security 2. area-owners.md owners column for area-System.Security (moved from consultants) This ensures they receive direct notifications for area-System.Security, consistent with how they're configured for area-System.Runtime.Intrinsics. Co-authored-by: agocke <[email protected]>
Member
|
@SamMonoRT @phil-allen-msft @jeffhandley @karelz I synced up the area notifications with area owners. These were out of date. Can you take a look and make sure this is correct for your team? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes area label notification subscribers between .github/policies/resourceManagement.yml and docs/area-owners.md. The changes ensure that notifications are sent to the correct area leads and teams, with outdated individual subscribers being replaced by team references (e.g., dotnet/jit-contrib, dotnet/interop-contrib, dotnet/runtime-infrastructure) or updated to reflect current ownership assignments.
Key changes include:
- Adding area leads to notification lists where they were missing (e.g., @agocke, @karelz, @phil-allen-msft)
- Replacing individual subscribers with team references for better maintainability (e.g.,
dotnet/jit-contrib,dotnet/ilc-contrib,dotnet/interop-contrib) - Correcting GitHub handle casing for consistency (e.g.,
brzvlad→BrzVlad,SamMonoRT→sammonort) - Removing consultants from automatic notifications (they remain listed in area-owners.md for reference)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/area-owners.md | Updated owner assignments to reflect current team structures; added individual crypto experts (@bartonjs, @vcsjones) to several security-related areas; corrected lead assignments for archived components and infrastructure areas |
| .github/policies/resourceManagement.yml | Synchronized notification subscribers with area-owners.md; added missing area leads to notification lists; replaced individual contributors with team references; corrected GitHub handle casing; removed outdated or consultant-only subscribers |
| | area-System.IO | @jeffhandley | @dotnet/area-system-io | | | ||
| | area-System.IO.Compression | @karelz | @dotnet/area-system-io-compression | Included:<ul><li>System.Formats.Tar</li><li>System.IO.Packaging</li></ul> | | ||
| | area-System.IO.Hashing | @jeffhandley | @dotnet/area-system-io-hashing | APIs within the System.IO.Hashing namespace, which align more with cryptography than with I/O | | ||
| | area-System.IO.Hashing | @jeffhandley | @bartonjs @vcsjones @dotnet/area-system-io-hashing | APIs within the System.IO.Hashing namespace, which align more with cryptography than with I/O | |
There was a problem hiding this comment.
Inconsistent ordering between resourceManagement.yml and area-owners.md. In area-owners.md line 102, the owners are listed as "@bartonjs @vcsjones @dotnet/area-system-io-hashing" (individuals first, then team), but in resourceManagement.yml lines 1202-1204, they are listed as "dotnet/area-system-io-hashing", "bartonjs", "vcsjones" (team first, then individuals). While this doesn't affect functionality, consistent ordering between the two files would improve maintainability.
Suggested change
| | area-System.IO.Hashing | @jeffhandley | @bartonjs @vcsjones @dotnet/area-system-io-hashing | APIs within the System.IO.Hashing namespace, which align more with cryptography than with I/O | | |
| | area-System.IO.Hashing | @jeffhandley | @dotnet/area-system-io-hashing @bartonjs @vcsjones | APIs within the System.IO.Hashing namespace, which align more with cryptography than with I/O | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
resourceManagement.ymlnotification configuration had areas out of sync witharea-owners.md. Notifications were being sent to incorrect or outdated subscribers, and area leads were not always included in notifications. Additionally,area-owners.mdhad incorrect or incomplete entries for several areas.Updated
.github/policies/resourceManagement.ymlto sync all area label notification subscribers withdocs/area-owners.md. The approach prioritizes usingdotnet/*teams for automated notifications while ensuring individual experts are properly listed in the owners column ofarea-owners.mdwhere they should receive direct notifications.