Add multi-dim array support to the interpreter #115916
Draft
+161
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Open
3 tasks
janvorli
reviewed
May 28, 2025
| } | ||
| else | ||
| { | ||
| AddIns(INTOP_NEWOBJ); | ||
| m_pLastNewIns->data[1] = GetDataItemIndex(ctorClass); | ||
| m_pLastNewIns->data[2] = (m_compHnd->getArrayRank(ctorClass) > 0) |
There was a problem hiding this comment.
Is it possible to get a rank of 0? What does it mean in that case?
There was a problem hiding this comment.
Ah, got it, we call this even for non-arrays and that's what gets us rank of 0.
There was a problem hiding this comment.
Once this is rebased onto the updated string ctors PR, it will be using a dedicated opcode so it should be less confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on (contains) #115914
Implements ctors and method calls for multidimensional arrays. There are still scenarios around multi-dim arrays that don't work (comment regarding this is in Interpreter.cs)
To do this I had to make the newobj opcode bigger so it has room to stash a helper ftn (used to invoke the mdarray ctor).