Zip async implementation follow-up: Fix failures in wasm and add extra tests #114798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
requested review from
stephentoub,
adamsitnik,
ViktorHofer and
jozkee
There was a problem hiding this comment.
Pull Request Overview
This PR addresses asynchronous failures on wasm platforms by removing synchronous calls in async tests and adding extra tests for zip archive entries. Key changes include:
- Replacing .Result with proper await calls to eliminate monitor wait issues on wasm.
- Removing the redundant PopulateStream method in favor of direct async file reading.
- Un-commenting and updating tests to correctly count WriteAsync calls.
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
…unt the Async write calls, not the sync ones, and add the rest of the async methods.
…ite and EndWrite.
carlossanlop
force-pushed
the
ZipAsyncFollowup
branch
from
ee92799 to
4e954e1
Compare
carlossanlop
commented
Apr 17, 2025
src/libraries/System.IO.Compression/tests/ZipArchive/zip_UpdateTests.cs
Outdated
Show resolved
Hide resolved
|
All the wasm legs passed. Can I please get a review and hopefully a sign-off? @adamsitnik I'm still working on improving the Fuzzing logic. I am preparing a separate followup PR that will capture only a few exceptions per your suggestion in my previous PR. |
This was referenced Apr 18, 2025
Open
lewing
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114769
Follow-up of #114421
Should revert #114801
Need to remove
.Resultfrom async tests in the zip_InvalidParametersAndStrangeFiles class, otherwise wasm throwsPlatformNotSupportedException - Cannot wait on monitors on this runtime.I also uncommented tests that were not passing because they needed to count the WriteAsync methods, not the sync ones. They're now passing.
I also added the rest of the async versions of the newest tests added by @edwardneal .