-
Notifications
You must be signed in to change notification settings - Fork 5k
Make CertificateRequest et al work with ML-DSA #114471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Add ctors to CertificateRequest * Enlighten CertificateRequest that future signing algorithms might not require a HashAlgorithmName * Add support to CertificateRequestListBuilder * Add cert.GetMLDsaPublicKey/GetMLDsaPrivateKey/CopyWithPrivateKey to power the above.
Note regarding the
|
1 similar comment
Note regarding the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 30 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/libraries/System.Security.Cryptography/src/Resources/Strings.resx: Language not supported
- src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/MLDsa/MLDsaTestImplementation.cs:41
- xUnit does not provide an Assert.Fail() method by default. Consider replacing Assert.Fail() with Assert.True(false, 'Failure message') or throwing an appropriate exception (e.g. new Xunit.Sdk.XunitException('Failure')) to indicate test failure.
ExportMLDsaPrivateSeedHook = _ => Assert.Fail(),
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/CertificateRequest.cs:24
- [nitpick] Changing the type of _key from AsymmetricAlgorithm? to object? reduces type safety and clarity regarding supported key types. Consider renaming the field or adding a comment to clearly indicate that it can hold multiple key types (e.g. RSA, ECDsa, MLDsa).
private readonly object? _key;
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
@vcsjones-bot test e9cb11d with openssl-3.5 |
This is the ML-DSA specific parts from #114357.
Contributes to #113502.