don't run drawing tests on Mono #111208
Merged
don't run drawing tests on Mono #111208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on Mono, as it's not supported
adamsitnik
added
test-enhancement
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkotas
approved these changes
Jan 8, 2025
3 tasks
|
@adamsitnik could you backport this to .NET 9, to fix the failure on CI there? |
@matouskozak sure! I'll do it today. |
adamsitnik
added a commit
to adamsitnik/runtime
that referenced
this pull request
Jan 16, 2025
* don't run Drawing-related tests that do things like creating Bitmaps on Mono, as it's not supported (it does not support ComWrappers) * re-enable the tests
4 tasks
jkotas
pushed a commit
that referenced
this pull request
Jan 17, 2025
…removal (#111508) * [NRBF] Reduce the most time-consuming test case to avoid timeouts for checked builds (#110550) * don't run drawing tests on Mono (#111208) * don't run Drawing-related tests that do things like creating Bitmaps on Mono, as it's not supported (it does not support ComWrappers) * re-enable the tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #107553 a group of tests was failing because
Bitmapis not supported on Mono.The code was already using a guard for that:
https://github.com/dotnet/runtime/blob/06a6ea78fbe99fd86f2f46df9b046cb4c4ea18a7/src/libraries/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTestData.cs#L1346-L1349
I decided to update the logic behind
PlatformDetection.IsDrawingSupportedas I assumed it's simply not supported and could help in other places. But I need a confirmation from @matouskozak or someone else from the Mono team.fixes #107553