Skip to content

CI tests not running all commands #85621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BruceForstall opened this issue May 2, 2023 · 1 comment · Fixed by #85622
Closed

CI tests not running all commands #85621

BruceForstall opened this issue May 2, 2023 · 1 comment · Fixed by #85622
Assignees
@BruceForstall
Labels
area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-clean-ci-optional Blocking optional rolling runs
Milestone
8.0.0

Comments

@BruceForstall
Copy link
Contributor

BruceForstall commented May 2, 2023 •
edited by build-analysis bot
Loading

#85183 changed the Helix commands to exit that script running Helix commands, which causes the HelixPostCommands and other Helix injected commands to not run.

E.g., previous output looks like:

[XUnitLogChecker]: Item 'Directed_1' did complete successfully!
ERROR: The process "corerun.exe" not found.
2023-04-26T20:04:39.112Z	INFO   	run.py	run(48)	main	Beginning reading of test results.
2023-04-26T20:04:39.112Z	INFO   	run.py	__init__(42)	read_results	Searching 'C:\h\w\AD5908C9\w\AFF509AB\e' for test results files
2023-04-26T20:04:39.112Z	INFO   	run.py	__init__(48)	read_results	Found results file C:\h\w\AD5908C9\w\AFF509AB\e\JIT\Directed\Directed_1\Directed_1.testResults.xml with format xunit
2023-04-26T20:04:39.128Z	INFO   	run.py	__init__(42)	read_results	Searching 'C:\h\w\AD5908C9\w\AFF509AB\uploads' for test results files
2023-04-26T20:04:39.143Z	INFO   	run.py	packing_test_reporter(30)	report_results	Packing 134 test reports to 'C:\h\w\AD5908C9\w\AFF509AB\e\__test_report.json'
2023-04-26T20:04:39.143Z	INFO   	run.py	packing_test_reporter(33)	report_results	Packed 23289 bytes
['Directed_1' END OF WORK ITEM LOG: Command exited with 0]

Now, the output after the [XUnitLogChecker] line is missing. I'm not sure what the implications are of all the test results processing not happening.

This causes the superpmi-collect pipeline to fail completely, since it does a lot of work in the HelixPostCommands phase.

Known Issue Error Message

Fill the error message using known issues guidance.

{
  "ErrorMessage": "",
  "BuildRetry": false
}

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@BruceForstall BruceForstall added area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-clean-ci-optional Blocking optional rolling runs labels May 2, 2023
@BruceForstall BruceForstall added this to the 8.0.0 milestone May 2, 2023
@BruceForstall BruceForstall self-assigned this May 2, 2023
@ghost
Copy link

ghost commented May 2, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

#85183 changed the Helix commands to exit that script running Helix commands, which causes the HelixPostCommands and other Helix injected commands to not run.

E.g., previous output looks like:

[XUnitLogChecker]: Item 'Directed_1' did complete successfully!
ERROR: The process "corerun.exe" not found.
2023-04-26T20:04:39.112Z	INFO   	run.py	run(48)	main	Beginning reading of test results.
2023-04-26T20:04:39.112Z	INFO   	run.py	__init__(42)	read_results	Searching 'C:\h\w\AD5908C9\w\AFF509AB\e' for test results files
2023-04-26T20:04:39.112Z	INFO   	run.py	__init__(48)	read_results	Found results file C:\h\w\AD5908C9\w\AFF509AB\e\JIT\Directed\Directed_1\Directed_1.testResults.xml with format xunit
2023-04-26T20:04:39.128Z	INFO   	run.py	__init__(42)	read_results	Searching 'C:\h\w\AD5908C9\w\AFF509AB\uploads' for test results files
2023-04-26T20:04:39.143Z	INFO   	run.py	packing_test_reporter(30)	report_results	Packing 134 test reports to 'C:\h\w\AD5908C9\w\AFF509AB\e\__test_report.json'
2023-04-26T20:04:39.143Z	INFO   	run.py	packing_test_reporter(33)	report_results	Packed 23289 bytes
['Directed_1' END OF WORK ITEM LOG: Command exited with 0]

Now, the output after the [XUnitLogChecker] line is missing. I'm not sure what the implications are of all the test results processing not happening.

This causes the superpmi-collect pipeline to fail completely, since it does a lot of work in the HelixPostCommands phase.

Author: BruceForstall
Assignees: BruceForstall
Labels:

area-Infrastructure-coreclr, blocking-clean-ci, blocking-clean-ci-optional
Milestone: 8.0.0

BruceForstall added a commit to BruceForstall/runtime that referenced this issue May 2, 2023
@BruceForstall
Fix Helix command lines error code handling
d19060c 
The `HelixCommandLines` group must not call `exit` on the script
or the HelixPostCommands and potentially other injected commands
will not run.

Instead, figure out what the exit code should be, and set it properly
(as `ERRORLEVEL` on Windows or `$?` on non-Windows).

Fixes dotnet#85621
@BruceForstall BruceForstall mentioned this issue May 2, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label May 2, 2023
BruceForstall added a commit that referenced this issue May 2, 2023
@BruceForstall
Fix Helix command lines error code handling (#85622)
a66af19 
The `HelixCommandLines` group must not call `exit` on the script
or the HelixPostCommands and potentially other injected commands
will not run.

Instead, figure out what the exit code should be, and set it properly
(as `ERRORLEVEL` on Windows or `$?` on non-Windows).

Fixes #85621
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label May 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@BruceForstall BruceForstall

Labels
area-Infrastructure-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-clean-ci-optional Blocking optional rolling runs
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix Helix command lines error code handling BruceForstall/runtime
1 participant
@BruceForstall