-
Notifications
You must be signed in to change notification settings - Fork 5k
Expose WebSocketMessageFlags
in ClientWebSocket
#77783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @dotnet/ncl Issue DetailsIn #31088 compression support in WebSocket was introduced. There was added However, this flag was added only in
|
I've not quite followed the proposal. ClientWebSocket derives from WebSocket, inheriting all the APIs added there, and its implementation wraps ManagedWebSocket that implements the compression. What is the specific API that would be added to ClientWebSocket? |
@stephentoub we should add runtime/src/libraries/System.Net.WebSockets.Client/src/System/Net/WebSockets/ClientWebSocket.cs Lines 145 to 149 in 64b3ee4
runtime/src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/WebSocket.cs Lines 56 to 64 in 64b3ee4
|
Thanks. This isn't about missing API, then, it's a bug. ClientWebSocket should be overriding |
Triage: We should fix this in 8.0, looks like we're missing test coverage as well. |
Reopening for backport |
In #31088 compression support in WebSocket was introduced. There was added
WebSocketMessageFlags.DisableCompression
flag which is needed to turn off compression i.e. when sending data containing secrets -- it helps to avoid CRIME/BREACH attacks.However, this flag was added only in
WebSocket
and not inClientWebSocket
which is supposed to manage messages. We need to exposeDisableCompression
flag inSendAsync
methods as well as it is done forEndOfMessage
flag.The text was updated successfully, but these errors were encountered: