-
Notifications
You must be signed in to change notification settings - Fork 6k
Add WebSockets conceptual doc #32058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebSockets conceptual doc #32058
Conversation
af37422
to
3f38e06
Compare
3f38e06
to
feb0bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thank you. We'll when you make the suggested changes. We also need a TOC entry for this article.
Thanks a lot for your work on this! It would be great if we could also have a fully runnable example on connecting+sending+receiving+closing e.g. with a public echo endpoint (I guess that would only exist for H/1) -- and the code snippets in the article would be parts of that example, like in https://github.com/dotnet/docs/blob/main/docs/fundamentals/networking/sockets/socket-services.md?plain=1#L31 (with code in https://github.com/dotnet/docs/tree/main/docs/fundamentals/networking/snippets/socket). If that would be hard/take a lot of time to do, let's create a follow-up issue. But I think it's important that the conceptual doc would cover all the lifecycle of a WebSocket, not only connecting. |
Co-authored-by: David Pine <[email protected]>
@IEvangelist should I add it manually or it can be done automatically? |
It needs to be added manually as part of this PR. Where does the new article belong? See TOC for details. Here is probably where you'd likely want to put it, somewhere beneath the other Networking content. https://github.com/dotnet/docs/blob/main/docs/fundamentals/toc.yml#L2585 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we'll - thank you 🙏
Summary
Added WebSockets conceptual doc with examples and tips
Fixes #31759
Preview https://review.learn.microsoft.com/en-us/dotnet/fundamentals/networking/websockets?branch=pr-en-us-32058