[WIP][Personal] TypeOf over multiple types. #21034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Grammar:= { TypeName (, TypeName )* }`
Added a new SyntaxNode TypeArray that inherit TypeSyntax.
Refining the parser. Add text to resource.resx Updated the PublicAPI.Unshipped. --- Note: Fails at binding stage.
Broken parsing of `TypeOf obj Is type`.
Fixing the parsing.
NOTE: error throw when hove over a type within array. ``` --------------------------- Assertion Failed: Abort=Quit, Retry=Debug, Ignore=Continue --------------------------- Unexpected TypeArray syntax does not have diagnostics at Microsoft.CodeAnalysis.VisualBasic.Binder.BindExpression(ExpressionSyntax node, Boolean isInvocationOrAddressOf, Boolean isOperandOfConditionalBranch, Boolean eventContext, DiagnosticBag diagnostics) at Microsoft.CodeAnalysis.VisualBasic.Binder.BindNamespaceOrTypeOrExpressionSyntaxForSemanticModel(ExpressionSyntax node, DiagnosticBag diagnostics) at Microsoft.CodeAnalysis.VisualBasic.VBSemanticModel.Bind(Binder binder, SyntaxNode node, DiagnosticBag diagnostics) at Microsoft.CodeAnalysis.VisualBasic.MemberSemanticModel.GetBoundNodes(SyntaxNode node) at Microsoft.CodeAnalysis.VisualBasic.MemberSemanticModel.GetLowerBoundNode(VisualBasicSyntaxNode node) at Microsoft.CodeAnalysis.VisualBasic.MemberSemanticModel.GetBoundNodeSummary(VisualBasicSyntaxNode node) at Microsoft.CodeAnalysis.VisualBasic.MemberSemanticModel.GetExpressionTypeInfo(ExpressionSyntax node, CancellationToken cancellationToken) at Microsoft.CodeAnalysi...... <truncated> ```
Contributor
Author
|
How do I initiate the lowering aspects of the compilation? My breakpoints are not being hit. |
Pilchie
added
the
PR For Personal Review Only
jcouv
added
Area-Compilers
Community
AdamSpeight2008
force-pushed
the
master-typeof
branch
from
863abd3 to
4dae2df
Compare
AdamSpeight2008
force-pushed
the
master-typeof
branch
from
95e2aeb to
863abd3
Compare
AdamSpeight2008
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This an experimental work in progress.
Proposal TypeOf Many.