Increase Sorting invocations per iteration #3202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase by 10x, since the benchmark currently runs each iteration in 10ms or so, and we'd prefer 100ms.
AndyAyersMS
force-pushed
the
UpInvocationsPerIterationForSorting
branch
from
271f741 to
a3fffce
Compare
AndyAyersMS
changed the title
adamsitnik
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
LGTM, thank you for identifying and applying the fix @AndyAyersMS !
|
the build failure is unrelated (NativeAOT compilation failed with OOM), the PR can be merged, but I don't have the permissions to merge on red anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase by 10x, since the benchmark currently runs each iteration
in 10ms or so, and we'd prefer 100ms.