[2025/06/02] Candidate - In Flight Branch #29754
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements several updates to support the inflight branch process, including new label options and control pages for testing, improved background rendering and event handling, and asset management adjustments for HybridWebView. Key changes include:
- Addition of new XAML pages for label options and control.
- Updates to handlers and factories in iOS, Windows, and Android to improve rendering, event subscription, and looping behavior.
- Consolidation of HybridWebView JavaScript assets and updates to project files and pipelines.
Reviewed Changes
Copilot reviewed 348 out of 348 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Label/LabelOptionsPage.xaml | New XAML UI for label options. |
| src/Controls/tests/TestCases.HostApp/FeatureMatrix/Label/LabelControlPage.xaml(.cs) | New page and code-behind added for label control testing. |
| src/Controls/tests/TestCases.HostApp/CoreViews/CorePageView.cs | Updated gallery pages with additions for shadow feature and label control. |
| src/Controls/tests/DeviceTests/Resources/Raw/HybridTestRoot/scripts/HybridWebView.js | Removed duplicate HybridWebView script. |
| src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj | Updated asset reference to point to a centralized HybridWebView.js file. |
| src/Controls/src/Core/Platform/iOS/Extensions/BrushExtensions.cs | Improved background layer check with boundary validations. |
| src/Controls/src/Core/Handlers/Shell/ShellItemHandler.Windows.cs | Added Shell.Navigated event subscription for search updates. |
| src/Controls/src/Core/Handlers/Items2/iOS/ItemsSourceFactory2.cs | Unified fallback to LoopListSource2 for consistent looping behavior. |
| src/Controls/src/Core/Handlers/Items/CarouselViewHandler.Windows.cs | Added null check for ItemsSource in looping logic and scroll view handling. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs | Extended search appearance tracking to update character spacing. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarTracker.cs & SearchHandlerAppearanceTracker.cs | Minor adjustments for flyout icon selection and letter spacing updates. |
| src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/ContextActionCell.cs | Refactored background image rendering with UIGraphicsImageRenderer. |
| Project files (csproj, ui-tests.yml, Directory.Build.targets) | Updated to reference consolidated assets and improve build pipeline behavior. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
* [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <[email protected]> Co-authored-by: Rui Marinho <[email protected]> Co-authored-by: Gerald Versluis <[email protected]> Co-authored-by: Dhivya-SF4094 <[email protected]>
* fix added * Test added * snap added
…29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tion Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot.
… at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image
* Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ely on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml
…ouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots
* Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <[email protected]>
PureWeen
force-pushed
the
inflight/candidate
branch
from
58e3081 to
4b537ae
Compare
… 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about inflight process check
https://github.com/dotnet/maui/wiki/Inflight-Branch-Process