Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert accessibility features on template #27322

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

tj-devel709
Copy link
Member

@tj-devel709 tj-devel709 commented Jan 23, 2025

Description of Change

These appears to be a bug with CollectionView2 when trying to use these changes in our template. For the time being, we should keep the BindableLayout and make the BindableLayout more accessible for keyboard users.

This PR reverts #27222 and #27224

Issues Fixed

@tj-devel709 tj-devel709 added area-templates Project templates, Item Templates for Blazor and MAUI t/a11y Relates to accessibility labels Jan 23, 2025
@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 20:30
@tj-devel709 tj-devel709 requested a review from a team as a code owner January 23, 2025 20:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/Templates/src/templates/maui-mobile/Pages/MainPage.xaml: Language not supported
  • src/Templates/src/templates/maui-mobile/Pages/ProjectListPage.xaml: Language not supported
@jfversluis jfversluis merged commit 246a43f into main Jan 24, 2025
20 checks passed
@jfversluis jfversluis deleted the revert-CVA11yTemplate branch January 24, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-templates Project templates, Item Templates for Blazor and MAUI t/a11y Relates to accessibility
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants