[CoreSpotlight] Update bindings up to Xcode 27.0 Beta 3#26158
[CoreSpotlight] Update bindings up to Xcode 27.0 Beta 3#26158dalexsoto wants to merge 2 commits into
Conversation
Bind the Xcode 27 protection-class metadata on CSSearchableIndex, add CSSearchableIndexDescription, and expose the new delegate callback for protection-class-specific item retrieval on iOS, macOS, and Mac Catalyst. Preserve previously shipped CoreSpotlight fields and option enums on unsupported platforms until XAMCORE_5_0, add Flags metadata to the NS_OPTIONS enums, and move the compatibility diagnostics into xtro ignore files. Remove the resolved per-platform CoreSpotlight todo files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b96fb7cb-f82d-4cd4-9b60-a7f899f3b42d
There was a problem hiding this comment.
Pull request overview
Updates the CoreSpotlight binding surface to match Xcode 27.0 Beta 3 additions while maintaining binary compatibility for previously shipped (but incorrect) API exposure until XAMCORE_5_0.
Changes:
- Adds Xcode 27 protection-class APIs on
CSSearchableIndex, introducesCSSearchableIndexDescription, and adds the new protection-class-specificCSSearchableIndexDelegatecallback. - Preserves previously shipped cross-platform CoreSpotlight surfaces behind
#if XAMCORE_5_0and moves their xtro diagnostics to*.ignorefor compatibility. - Removes resolved CoreSpotlight xtro
*.todofiles.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/corespotlight.cs | Adds new CoreSpotlight bindings (protection class APIs, new type, new delegate callback) and guards compatibility surfaces with XAMCORE_5_0. |
| tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreSpotlight.ignore | Moves resolved CoreSpotlight xtro findings to compatibility ignores (kept until XAMCORE_5_0). |
| tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CoreSpotlight.ignore | Moves resolved CoreSpotlight xtro findings to compatibility ignores (kept until XAMCORE_5_0). |
| tests/xtro-sharpie/api-annotations-dotnet/tvOS-CoreSpotlight.ignore | Documents and ignores incorrectly exposed tvOS CoreSpotlight APIs kept until XAMCORE_5_0. |
| tests/xtro-sharpie/api-annotations-dotnet/iOS-CoreSpotlight.todo | Removed resolved xtro todo entries for CoreSpotlight. |
| tests/xtro-sharpie/api-annotations-dotnet/MacCatalyst-CoreSpotlight.todo | Removed resolved xtro todo entries for CoreSpotlight. |
| tests/xtro-sharpie/api-annotations-dotnet/macOS-CoreSpotlight.todo | Removed resolved xtro todo entries for CoreSpotlight. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #7f8545a] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 195 tests passed 🎉 Tests counts✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
Expose NSFileProtectionType on the protection-class delegate callback by supporting parameter-only BindAs in protocol and model bindings, including dynamic, static, and managed-static registrar interface metadata lookup. Mark the previously shipped unsupported CoreSpotlight fields, enums, and consumers obsolete and hidden on affected platforms so their xtro compatibility ignores can be removed without breaking ABI. Add bgen and registrar runtime coverage, preserve inherited BindAs native types, and update the BindAs documentation and diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b96fb7cb-f82d-4cd4-9b60-a7f899f3b42d
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
Summary
CSSearchableIndexand the newCSSearchableIndexDescriptiontypeCSSearchableIndexDelegatecallbackXAMCORE_5_0and move their xtro diagnostics to compatibility ignoresValidation
make world